This is an archive of the discontinued LLVM Phabricator instance.

Differential D118889

[libc] Disable rtti/expections
ClosedPublic

Authored by gchatelet on Feb 3 2022, 4:38 AM.

Details

Reviewers
sivachandra
Commits
rGa33e98543a68: [libc] Disable rtti/expections
Summary

llvm-libc exhibits a C interface but its source is C++.
This patch explicitly disables the use of exceptions and RTTI when compiling the entrypoints.

Diff Detail

Event Timeline

gchatelet created this revision.Feb 3 2022, 4:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2022, 4:38 AM
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny. · View Herald Transcript
gchatelet requested review of this revision.Feb 3 2022, 4:38 AM
gchatelet added inline comments.Feb 3 2022, 4:42 AM
libc/cmake/modules/LLVMLibCObjectRules.cmake
16

This is cloned from LLVM' llvm_update_compile_flags but I'm not sure we want to support IBM's compiler at this point.

Harbormaster completed remote builds in B147348: Diff 405579.Feb 3 2022, 4:44 AM
gchatelet added a comment.Feb 7 2022, 4:22 AM

A gentle ping @sivachandra .

sivachandra accepted this revision.Feb 7 2022, 9:05 AM
sivachandra added inline comments.
libc/cmake/modules/LLVMLibCObjectRules.cmake
16

Up to you. We don't have any testing planned in the near future so it will be just bit rot.

This revision is now accepted and ready to land.Feb 7 2022, 9:05 AM
gchatelet updated this revision to Diff 406748.Feb 8 2022, 2:39 AM

Remove XL compiler flags and rebase

This revision was landed with ongoing or failed builds.Feb 8 2022, 2:46 AM
Closed by commit rGa33e98543a68: [libc] Disable rtti/expections (authored by gchatelet). · Explain Why
This revision was automatically updated to reflect the committed changes.
gchatelet marked an inline comment as done.
gchatelet added a commit: rGa33e98543a68: [libc] Disable rtti/expections.
Harbormaster completed remote builds in B148200: Diff 406748.Feb 8 2022, 2:59 AM

Revision Contents

PathSize
libc/
cmake/
modules/
9 lines

Diff 406750

libc/cmake/modules/LLVMLibCObjectRules.cmake

set(OBJECT_LIBRARY_TARGET_TYPE "OBJECT_LIBRARY") set(OBJECT_LIBRARY_TARGET_TYPE "OBJECT_LIBRARY")
function(_get_common_compile_options output_var) function(_get_common_compile_options output_var)
set(compile_options ${LLVM_CXX_STD_default} ${LIBC_COMPILE_OPTIONS_DEFAULT} ${ARGN}) set(compile_options ${LLVM_CXX_STD_default} ${LIBC_COMPILE_OPTIONS_DEFAULT} ${ARGN})
if(NOT ${LIBC_TARGET_OS} STREQUAL "windows") if(NOT ${LIBC_TARGET_OS} STREQUAL "windows")
set(compile_options ${compile_options} -fpie -ffreestanding) set(compile_options ${compile_options} -fpie -ffreestanding)
endif() endif()
if(LLVM_COMPILER_IS_GCC_COMPATIBLE)
list(APPEND compile_options "-fno-exceptions")
list(APPEND compile_options "-fno-unwind-tables")
list(APPEND compile_options "-fno-asynchronous-unwind-tables")
list(APPEND compile_options "-fno-rtti")
elseif(MSVC)
list(APPEND compile_options "/EHs-c-")
list(APPEND compile_options "/GR-")
endif()
gchateletAuthorUnsubmitted
Done
ReplyInline Actions

This is cloned from LLVM' llvm_update_compile_flags but I'm not sure we want to support IBM's compiler at this point.

gchatelet: This is cloned from LLVM' [[ https://github.com/llvm/llvm…
sivachandraUnsubmitted
Done
ReplyInline Actions

Up to you. We don't have any testing planned in the near future so it will be just bit rot.

sivachandra: Up to you. We don't have any testing planned in the near future so it will be just bit rot.
set(${output_var} ${compile_options} PARENT_SCOPE) set(${output_var} ${compile_options} PARENT_SCOPE)
endfunction() endfunction()
# Rule which is essentially a wrapper over add_library to compile a set of # Rule which is essentially a wrapper over add_library to compile a set of
# sources to object files. # sources to object files.
# Usage: # Usage:
# add_object_library( # add_object_library(
# <target_name> # <target_name>
▲ Show 20 Lines • Show All 315 Lines • Show Last 20 Lines