This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add CI without experimental features and don't exclude span from the tests
ClosedPublic

Authored by ldionne on Feb 1 2022, 2:41 PM.

Details

Summary

There is no reason for the parts of std::span that don't depend on ranges
to be disabled when ranges aren't provided. Also, to make sure the
"no-experimental-stuff" configuration is tested, add a CI job for it.

Diff Detail

Event Timeline

ldionne created this revision.Feb 1 2022, 2:41 PM
ldionne requested review of this revision.Feb 1 2022, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2022, 2:41 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
jloser added a subscriber: jloser.Feb 1 2022, 2:47 PM

Looks reasonable to me modulo my comment about missing the XFAIL: apple-clang-12.0.0 on libcxx/test/std/containers/views/span.cons/deduct.pass.cpp

libcxx/test/std/containers/views/span.cons/deduct.pass.cpp
10

If we remove this, do we need to replace it with XFAIL: apple-clang-12.0.0? This goes for other span tests too, but most (all but this one?) have the XFAIL already.

ldionne added inline comments.Feb 1 2022, 3:02 PM
libcxx/test/std/containers/views/span.cons/deduct.pass.cpp
10

I don't think we need the XFAIL here because we are not using concepts in this test AFAICS. CI will let us know if we need to add it.

jloser accepted this revision.Feb 1 2022, 3:06 PM
jloser added inline comments.Feb 1 2022, 6:32 PM
libcxx/test/std/containers/views/span.cons/deduct.pass.cpp
10

Looks like you're right according to CI. :)

ldionne accepted this revision.Feb 2 2022, 7:48 AM
This revision is now accepted and ready to land.Feb 2 2022, 7:48 AM