There is no reason for the parts of std::span that don't depend on ranges
to be disabled when ranges aren't provided. Also, to make sure the
"no-experimental-stuff" configuration is tested, add a CI job for it.
Details
Details
- Reviewers
jloser ldionne - Group Reviewers
Restricted Project - Commits
- rG99ae4582318a: [libc++] Add CI without experimental features and don't exclude span from the…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Looks reasonable to me modulo my comment about missing the XFAIL: apple-clang-12.0.0 on libcxx/test/std/containers/views/span.cons/deduct.pass.cpp
libcxx/test/std/containers/views/span.cons/deduct.pass.cpp | ||
---|---|---|
10 | If we remove this, do we need to replace it with XFAIL: apple-clang-12.0.0? This goes for other span tests too, but most (all but this one?) have the XFAIL already. |
libcxx/test/std/containers/views/span.cons/deduct.pass.cpp | ||
---|---|---|
10 | I don't think we need the XFAIL here because we are not using concepts in this test AFAICS. CI will let us know if we need to add it. |
libcxx/test/std/containers/views/span.cons/deduct.pass.cpp | ||
---|---|---|
10 | Looks like you're right according to CI. :) |
If we remove this, do we need to replace it with XFAIL: apple-clang-12.0.0? This goes for other span tests too, but most (all but this one?) have the XFAIL already.