This change is a preparation for adapting the tests for
P2216 std::format improvements
Paths
| Differential D118717
[libc++][format[[nfc] Use string_view in tests. ClosedPublic Authored by Mordante on Feb 1 2022, 10:37 AM.
Details
Summary This change is a preparation for adapting the tests for P2216 std::format improvements
Diff Detail
Event Timeline• Quuxplusone added inline comments.
Comment Actions Thanks for the review.
This revision is now accepted and ready to land.Feb 4 2022, 2:02 PM Closed by commit rGe885b1137bcb: [libc++][format[[nfc] Use string_view in tests. (authored by Mordante). · Explain WhyFeb 8 2022, 8:31 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 406846 libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp
libcxx/test/std/utilities/format/format.functions/format.pass.cpp
libcxx/test/std/utilities/format/format.functions/format_tests.h
libcxx/test/std/utilities/format/format.functions/format_to.locale.pass.cpp
libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
libcxx/test/std/utilities/format/format.functions/format_to_n.locale.pass.cpp
libcxx/test/std/utilities/format/format.functions/format_to_n.pass.cpp
libcxx/test/std/utilities/format/format.functions/formatted_size.locale.pass.cpp
libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp
libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp
libcxx/test/std/utilities/format/format.functions/vformat.locale.pass.cpp
libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp
libcxx/test/std/utilities/format/format.functions/vformat_to.locale.pass.cpp
libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
|
FWIW, you could use const auto&... args to avoid such a long line (and to remove one C++20ism, although obviously removing the other template parameter would require more surgery).