This is an archive of the discontinued LLVM Phabricator instance.

Differential D118646

[lld-macho][test] Add test for UUID format
ClosedPublic

Authored by int3 on Jan 31 2022, 12:58 PM.

Details

Reviewers
keith
Group Reviewers
Restricted Project
Commits
rG96fb7d059da1: [lld-macho][test] Add test for UUID format

Diff Detail

Event Timeline

int3 created this revision.Jan 31 2022, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 12:58 PM
int3 requested review of this revision.Jan 31 2022, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 12:58 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
keith accepted this revision as: keith.Jan 31 2022, 3:29 PM
This revision is now accepted and ready to land.Jan 31 2022, 3:29 PM
thevinster added a subscriber: thevinster.Jan 31 2022, 3:34 PM
thevinster added inline comments.
lld/test/MachO/uuid.s
5

How come we can't do strict match here? It shouldn't ever change right? Also, {{([[:xdigit:]]{8})}} should be 12? LC_UUID shows 12 characters for me on that.

Harbormaster completed remote builds in B146743: Diff 404690.Jan 31 2022, 3:47 PM
int3 added inline comments.Jan 31 2022, 8:32 PM
lld/test/MachO/uuid.s
5

It shouldn't ever change right?

The UUID is a hash, so if we e.g. adjusted how LLD encodes something in the mach header, this would change. It would be annoying to have to update it every time something like that happens.

Also, by using a regex, we can make it clear what behavior is invariant across all binaries, not just this specific one.

LC_UUID shows 12 characters for me on that.

Whoops, you're right, good catch!

Closed by commit rG96fb7d059da1: [lld-macho][test] Add test for UUID format (authored by int3). · Explain WhyJan 31 2022, 8:52 PM
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG96fb7d059da1: [lld-macho][test] Add test for UUID format.

Revision Contents

PathSize
lld/
test/
MachO/
9 lines

Diff 404690

lld/test/MachO/uuid.s

  • This file was added.
# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
# RUN: %lld -lSystem %t.o -o %t
# RUN: llvm-dwarfdump --uuid %t | FileCheck %s
# CHECK: 4C4C44{{([[:xdigit:]]{2})}}-5555-{{([[:xdigit:]]{4})}}-A1{{([[:xdigit:]]{2})}}-{{([[:xdigit:]]{8})}}
thevinsterUnsubmitted
Not Done
ReplyInline Actions

How come we can't do strict match here? It shouldn't ever change right? Also, {{([[:xdigit:]]{8})}} should be 12? LC_UUID shows 12 characters for me on that.

thevinster: How come we can't do strict match here? It shouldn't ever change right? Also, `{{([[:xdigit…
int3AuthorUnsubmitted
Done
ReplyInline Actions

It shouldn't ever change right?

The UUID is a hash, so if we e.g. adjusted how LLD encodes something in the mach header, this would change. It would be annoying to have to update it every time something like that happens.

Also, by using a regex, we can make it clear what behavior is invariant across all binaries, not just this specific one.

LC_UUID shows 12 characters for me on that.

Whoops, you're right, good catch!

int3: > It shouldn't ever change right? The UUID is a hash, so if we e.g. adjusted how LLD encodes…
.globl _main
_main:
ret