[TableGen] Fix reporting from CodeGenSchedModels::checkCompleteness()

[jonpa]

Summary

Make the check for a complete SchedModel:s work as expected: report any supported instruction not having scheduler info in a complete SchedModel.

For unclear reasons there was a variable 'HadComleteModel' that caused e.g. new instructions for a new subtarget not to be reported. This variable is now simply removed as all in-tree targets build fine without it.

[RKSimon]

LGTM - I've added @MatzeB (original coder) as a reviewer but it looks like they aren't dealing with LLVM stuff atm

[MatzeB]

I don't remember why I wrote the way this way. Looking at this now the changes make sense to me!

[jonpa]

In D118628#3287861, @MatzeB wrote:

I don't remember why I wrote the way this way. Looking at this now the changes make sense to me!

thanks - good to know :-)

llvm/utils/TableGen/CodeGenSchedule.cpp

void CodeGenSchedModels::collectProcResources() {
   }
 
   ProcResourceDefs.clear();
   ProcResGroups.clear();
 }
 
 void CodeGenSchedModels::checkCompleteness() {
   bool Complete = true;
-  bool HadCompleteModel = false;
   for (const CodeGenProcModel &ProcModel : procModels()) {
     const bool HasItineraries = ProcModel.hasItineraries();
     if (!ProcModel.ModelDef->getValueAsBit("CompleteModel"))
       continue;
     for (const CodeGenInstruction *Inst : Target.getInstructionsByEnumValue()) {
       if (Inst->hasNoSchedulingInfo)
         continue;
       if (ProcModel.isUnsupported(*Inst))
         continue;
       unsigned SCIdx = getSchedClassIdx(*Inst);
       if (!SCIdx) {
-        if (Inst->TheDef->isValueUnset("SchedRW") && !HadCompleteModel) {
+        if (Inst->TheDef->isValueUnset("SchedRW")) {
           PrintError(Inst->TheDef->getLoc(),
                      "No schedule information for instruction '" +
                          Inst->TheDef->getName() + "' in SchedMachineModel '" +
                      ProcModel.ModelDef->getName() + "'");
           Complete = false;
         }
         continue;
       }
for (const CodeGenInstruction *Inst : Target.getInstructionsByEnumValue()) {
       });
       if (I == InstRWs.end()) {
         PrintError(Inst->TheDef->getLoc(), "'" + ProcModel.ModelName +
                                                "' lacks information for '" +
                                                Inst->TheDef->getName() + "'");
         Complete = false;
       }
     }
-    HadCompleteModel = true;
   }
   if (!Complete) {
     errs() << "\n\nIncomplete schedule models found.\n"
       << "- Consider setting 'CompleteModel = 0' while developing new models.\n"
       << "- Pseudo instructions can be marked with 'hasNoSchedulingInfo = 1'.\n"
       << "- Instructions should usually have Sched<[...]> as a superclass, "
          "you may temporarily use an empty list.\n"
       << "- Instructions related to unsupported features can be excluded with "