Page MenuHomePhabricator
Differential D118445

[clang][AVR] Set '-fno-use-cxa-atexit' to default
ClosedPublic
Actions

Authored by benshi001 on Jan 28 2022, 2:12 AM.

Details

Reviewers
aykevl
MaskRay
dylanmckay
Commits
rG653836251ac4: [clang][AVR] Set '-fno-use-cxa-atexit' to default
Summary

The avr-libc does not support '__cxa_atexit()'.

Diff Detail

Event Timeline

benshi001 created this revision.Jan 28 2022, 2:12 AM
Herald added a subscriber: Jim. · View Herald TranscriptJan 28 2022, 2:12 AM
benshi001 requested review of this revision.Jan 28 2022, 2:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 2:12 AM
Herald added subscribers: cfe-commits, jacquesguan. · View Herald Transcript
benshi001 added a comment.Jan 28 2022, 2:15 AM
This comment was removed by benshi001.
benshi001 updated this revision to Diff 404244.Jan 29 2022, 12:51 AM
benshi001 retitled this revision from [clang][AVR] Fix a crash in AVRTargetCodeGenInfo::getGlobalVarAddressSpace to [clang][AVR] Set '-fno-use-cxa-atexit' to default.
benshi001 edited the summary of this revision. (Show Details)
This comment was removed by benshi001.
benshi001 added a comment.Jan 29 2022, 12:54 AM

AVR is baremetal environment, it does not support __cxa_atexit()

benshi001 added a comment.Jan 29 2022, 1:29 AM
This comment was removed by benshi001.
Harbormaster completed remote builds in B146439: Diff 404244.Jan 29 2022, 1:38 AM
benshi001 added a comment.Jan 29 2022, 6:34 AM

fixes https://github.com/llvm/llvm-project/issues/50631

MaskRay accepted this revision.Jan 29 2022, 12:49 PM

LGTM.

This revision is now accepted and ready to land.Jan 29 2022, 12:49 PM
This revision was landed with ongoing or failed builds.Jan 29 2022, 6:27 PM
Closed by commit rG653836251ac4: [clang][AVR] Set '-fno-use-cxa-atexit' to default (authored by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rG653836251ac4: [clang][AVR] Set '-fno-use-cxa-atexit' to default.

Revision Contents
Changeset List

PathSize
clang/
lib/
CodeGen/
14 lines
Driver/
ToolChains/
5 lines
test/
Driver/
7 lines

Diff 404320

View Options

clang/lib/CodeGen/TargetInfo.cpp

Loading...
View Options

clang/lib/Driver/ToolChains/AVR.cpp

Loading...
View Options

clang/test/Driver/avr-toolchain.c

Loading...