This is an archive of the discontinued LLVM Phabricator instance.

[LLD][MinGW] Add --heap argument support
ClosedPublic

Authored by mati865 on Jan 27 2022, 1:22 PM.

Details

Summary

Noticed in https://github.com/msys2/MINGW-packages/pull/10567

Untested but should work fine judging by COFF driver code.

Diff Detail

Event Timeline

mati865 created this revision.Jan 27 2022, 1:22 PM
mati865 requested review of this revision.Jan 27 2022, 1:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2022, 1:22 PM
mstorsjo accepted this revision.Jan 29 2022, 2:03 PM

Thanks, I tested it and it seems to work fine. (FWIW the comma-separated form of the option is pretty hard to pass via -Wl through the compiler driver, but with -Xlinker --heap -Xlinker 1234,5678 it worked.)

This revision is now accepted and ready to land.Jan 29 2022, 2:03 PM
This revision was automatically updated to reflect the committed changes.