This is an archive of the discontinued LLVM Phabricator instance.

[lldb, win] Skip watchpoint tests on the Windows lldb bot
ClosedPublic

Authored by stella.stamenova on Jan 27 2022, 12:33 PM.

Details

Summary

The watchpoint tests are particularly fragile, so skip these on the Windows buildbot.

Diff Detail

Event Timeline

stella.stamenova requested review of this revision.Jan 27 2022, 12:33 PM
stella.stamenova created this revision.
JDevlieghere accepted this revision.Jan 27 2022, 12:35 PM

LGTM. We do the same thing downstream (https://ci.swift.org/view/LLDB/)

This revision is now accepted and ready to land.Jan 27 2022, 12:35 PM
gkistanova accepted this revision.Jan 27 2022, 1:01 PM

LGTM with a nit.

buildbot/osuosl/master/config/builders.py
1229

The flags either s or v, when you specify both, v gets ignored per current LIT implementation. I'd personally go with -v here.

stella.stamenova added inline comments.
buildbot/osuosl/master/config/builders.py
1229

I left these as they were after @omjavaid's change. I'm happy to change them since I agree with you, but my goal was to just skip the watchpoint category and not make any other changes.

stella.stamenova marked an inline comment as done.Jan 27 2022, 1:05 PM
This revision was landed with ongoing or failed builds.Jan 27 2022, 3:43 PM
This revision was automatically updated to reflect the committed changes.