Page MenuHomePhabricator

[lldb] Make ReadCStringFromMemory default to read from the file-cache.
ClosedPublic

Authored by augusto2112 on Jan 26 2022, 9:28 AM.

Diff Detail

Event Timeline

augusto2112 requested review of this revision.Jan 26 2022, 9:28 AM
augusto2112 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2022, 9:28 AM
aprantl accepted this revision.Jan 27 2022, 1:42 PM

force_live_memory=false means use the file cache iff:

  • the address has a Section
  • the section is read-only

Otherwise it reads from memory.

Based on that this looks safe to me.

This revision is now accepted and ready to land.Jan 27 2022, 1:42 PM