This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix the get_weekday test on glibc
ClosedPublic

Authored by mstorsjo on Jan 26 2022, 4:15 AM.

Details

Summary

This test feeds in the expected utf8 form of weekdays in various
languages, trying to match what libc++ has gathered internally
from strftime(). On glibc, the ru_RU.UTF-8 representation of the
tested weekday is spelled with upper case, while the existing
test reference is lower case.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Jan 26 2022, 4:15 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2022, 4:15 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Feb 11 2022, 9:03 AM

Thanks for this improvement! LGTM!

Quuxplusone accepted this revision.Feb 14 2022, 8:36 AM
This revision is now accepted and ready to land.Feb 14 2022, 8:36 AM
This revision was automatically updated to reflect the committed changes.