This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] Use bool allocators for vector<bool>::get_allocator test
ClosedPublic

Authored by CaseyCarter on Jan 24 2022, 1:02 PM.

Details

Reviewers
Quuxplusone
philnik
Mordante
Group Reviewers
Restricted Project
Summary

... to be consistent with other get_allocator tests, and to avoid requiring vector<T, allocator<U>> to be valid.

Diff Detail

Event Timeline

CaseyCarter requested review of this revision.Jan 24 2022, 1:02 PM
CaseyCarter created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 24 2022, 1:02 PM
Quuxplusone accepted this revision.Jan 24 2022, 1:52 PM
Quuxplusone added a subscriber: Quuxplusone.

LGTM if CI is green!

This revision is now accepted and ready to land.Jan 24 2022, 1:52 PM
philnik accepted this revision.Jan 25 2022, 3:34 AM
Mordante accepted this revision.Jan 25 2022, 9:26 AM
Mordante added a subscriber: Mordante.

LGTM!

@CaseyCarter Is there a reason you aren't landing this? You have commit access, right?

Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2022, 2:06 PM
CaseyCarter closed this revision.Jun 6 2022, 2:32 PM

I landed this months ago, but failed to autolink the Differential to the commit. This is officially closed by 93230ac1d2cf32419ce88fdd850f92a02bec5553.