Details
Details
- Reviewers
- ldionne 
- Group Reviewers
- Restricted Project 
- Commits
- rG5d3ab6a2bb36: [libc++][nfc] Include test_macros.h in more tests.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
| libcxx/test/std/concepts/concepts.lang/concept.assignable/assignable_from.compile.pass.cpp | ||
|---|---|---|
| 26 | I don't understand why this is needed in several of the places where you're including the file. For example, here, I don't see anything that uses a macro in test_macros.h. Am I missing it? | |
| libcxx/test/std/concepts/concepts.lang/concept.assignable/assignable_from.compile.pass.cpp | ||
|---|---|---|
| 26 | As discussed on Discord, there was some confusion about the policy whether or not to always include this header. The header should only be included when needed. So the unneeded occurrences have been removed. | |
I don't understand why this is needed in several of the places where you're including the file. For example, here, I don't see anything that uses a macro in test_macros.h. Am I missing it?