This is an archive of the discontinued LLVM Phabricator instance.

[libc++][nfc] Add TEST_HAS_NO_INT128.
ClosedPublic

Authored by Mordante on Jan 23 2022, 9:28 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG8f972cb0fd0c: [libc++][nfc] Add TEST_HAS_NO_INT128.
Summary

Avoid using the libc++ internal _LIBCPP_HAS_NO_INT128 in our tests.

I've created D117993 as an RFC to guard against using _LIBCPP_HAS_NO_INT128 in our tests in the future.

Diff Detail

Event Timeline

Mordante requested review of this revision.Jan 23 2022, 9:28 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2022, 9:28 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante edited the summary of this revision. (Show Details)Jan 23 2022, 9:39 AM
ldionne accepted this revision.Jan 24 2022, 8:29 AM
ldionne added a subscriber: ldionne.

Awesome, thanks a lot! Ship-it once CI passes.

This revision is now accepted and ready to land.Jan 24 2022, 8:29 AM
This revision was landed with ongoing or failed builds.Jan 27 2022, 8:31 AM
This revision was automatically updated to reflect the committed changes.