Make sure dsymutil temporary files (with names derived from input files) get created under %T.

[echristo]

LGTM.

-eric

[friss]

Wait wait wait. As the comment just bellow your edit state, this test isn't supposed to create files. If it did, then it's a bug. What did you see?

[friss]

(Of course you can go ahead with the patch if it fixes an issue, I just need to understand what's happening)

[tra]

Change in r244087:
getOutputFileName() apparently derives the name of the temp file from the
input file name and that temp file does get created.
Or, rather, fails to get created if source tree with input files is
read-only.

--Artem

• msg-28753-558.txt162 BDownload

[friss]

Thanks. Yeah I create the temporary files to ensure uniqueness. They never get written to, but they get created and deleted. I'll change the logic not to create them.

test/tools/dsymutil/fat-binary-output.test

-RUN: llvm-dsymutil -verbose -no-output %p/Inputs/fat-test.dylib -oso-prepend-path %p | FileCheck %s
+RUN: mkdir %T/Inputs
+RUN: cp %p/Inputs/fat-test.* %T/Inputs
+RUN: llvm-dsymutil -verbose -no-output %T/Inputs/fat-test.dylib -oso-prepend-path %T | FileCheck %s
 
 This test doesn't produce any filesytstem output, we just look at the verbose
 log output.
 
 For each arch in the binary, check that we emit the right triple with the right
 file and the right symbol inside it (each slice has a different symbol, so that
 means that the logic is looking at the right file slice too).