This is an archive of the discontinued LLVM Phabricator instance.

[docs] There are more than three bit storage containers.
ClosedPublic

Authored by HsiangKai on Jan 20 2022, 5:49 PM.

Details

Summary

To avoid listing all the bit containers in the title and do not use the specific number for the number of bit containers.

Diff Detail

Event Timeline

HsiangKai requested review of this revision.Jan 20 2022, 5:49 PM
HsiangKai created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 5:49 PM
dexonsmith accepted this revision.Jan 21 2022, 3:37 PM

LGTM, with a couple of comments inline.

llvm/docs/ProgrammersManual.rst
2401

This should list SmallBitVector as well, right?

2404–2405

Is there a way of wording this to avoid having to update the count in the future? If not, LGTM as is.

This revision is now accepted and ready to land.Jan 21 2022, 3:37 PM

Address dexonsmith's comments.

HsiangKai added inline comments.Jan 23 2022, 11:45 PM
llvm/docs/ProgrammersManual.rst
2401

I removed the container list in the title. I think it is not necessary to list them in the title, just like "String-like containers" section.

2404–2405

How about to use 'several' here?

HsiangKai retitled this revision from [docs] There are four bit storage containers. to [docs] There are more than three bit storage containers..Jan 23 2022, 11:46 PM
HsiangKai edited the summary of this revision. (Show Details)
dexonsmith accepted this revision.Jan 24 2022, 6:46 PM

LGTM, thanks!