This is an archive of the discontinued LLVM Phabricator instance.

llvm/docs/ProgrammersManual.rst
2401	This should list `SmallBitVector` as well, right?
2404–2405	Is there a way of wording this to avoid having to update the count in the future? If not, LGTM as is.

This revision is now accepted and ready to land.Jan 21 2022, 3:37 PM

Address dexonsmith's comments.

HsiangKai added inline comments.Jan 23 2022, 11:45 PM

llvm/docs/ProgrammersManual.rst
2401	I removed the container list in the title. I think it is not necessary to list them in the title, just like "String-like containers" section.
2404–2405	How about to use 'several' here?

HsiangKai retitled this revision from [docs] There are four bit storage containers. to [docs] There are more than three bit storage containers..Jan 23 2022, 11:46 PM

HsiangKai edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B145167: Diff 402408.Jan 24 2022, 1:17 AM

LGTM, thanks!

Closed by commit rG901dd53cbf61: [docs] There are more than three bit storage containers. (authored by HsiangKai). · Explain WhyJan 25 2022, 2:09 AM

This revision was automatically updated to reflect the committed changes.

HsiangKai added a commit: rG901dd53cbf61: [docs] There are more than three bit storage containers..

Revision Contents

Path

Size

llvm/

docs/

ProgrammersManual.rst

4 lines

Diff 402804

llvm/docs/ProgrammersManual.rst

	Show First 20 Lines • Show All 2,392 Lines • ▼ Show 20 Lines
	they are generally very expensive (each insertion requires a malloc).			they are generally very expensive (each insertion requires a malloc).

	std::multimap is useful if you want to map a key to multiple values, but has all			std::multimap is useful if you want to map a key to multiple values, but has all
	the drawbacks of std::map. A sorted vector or some other approach is almost			the drawbacks of std::map. A sorted vector or some other approach is almost
	always better.			always better.

	.. _ds_bit:			.. _ds_bit:

	Bit storage containers (BitVector, SparseBitVector, CoalescingBitVector)			Bit storage containers
				dexonsmithUnsubmitted Not Done Reply Inline Actions This should list `SmallBitVector` as well, right? dexonsmith: This should list `SmallBitVector` as well, right?
				HsiangKaiAuthorUnsubmitted Done Reply Inline Actions I removed the container list in the title. I think it is not necessary to list them in the title, just like "String-like containers" section. HsiangKai: I removed the container list in the title. I think it is not necessary to list them in the…
	------------------------------------------------------------------------			------------------------------------------------------------------------

	There are three bit storage containers, and choosing when to use each is			There are several bit storage containers, and choosing when to use each is
	relatively straightforward.			relatively straightforward.
				dexonsmithUnsubmitted Not Done Reply Inline Actions Is there a way of wording this to avoid having to update the count in the future? If not, LGTM as is. dexonsmith: Is there a way of wording this to avoid having to update the count in the future? If not, LGTM…
				HsiangKaiAuthorUnsubmitted Done Reply Inline Actions How about to use 'several' here? HsiangKai: How about to use 'several' here?

	One additional option is ``std::vector<bool>``: we discourage its use for two			One additional option is ``std::vector<bool>``: we discourage its use for two
	reasons 1) the implementation in many common compilers (e.g. commonly			reasons 1) the implementation in many common compilers (e.g. commonly
	available versions of GCC) is extremely inefficient and 2) the C++ standards			available versions of GCC) is extremely inefficient and 2) the C++ standards
	committee is likely to deprecate this container and/or change it significantly			committee is likely to deprecate this container and/or change it significantly
	somehow. In any case, please don't use it.			somehow. In any case, please don't use it.

	.. _dss_bitvector:			.. _dss_bitvector:
	▲ Show 20 Lines • Show All 1,682 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[docs] There are more than three bit storage containers.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 402804

llvm/docs/ProgrammersManual.rst

[docs] There are more than three bit storage containers.
ClosedPublic