This is an archive of the discontinued LLVM Phabricator instance.

Differential D117771

[IRGen] Do not overwrite existing attributes in CGCall.
AbandonedPublicDraft

Authored by fhahn on Jan 20 2022, 4:10 AM.

Details

Reviewers
None
Summary

When adding new attributes, already added attributes are dropped. While
this appears to be a longstanding issue, this was highlighted by D105169
which dropped a lot of attributes due to adding the new noundef
attribute.

Ahmed Bougacha (@ab) tracked down the issue and provided the fix in
CGCall.cpp. I bundled it up and updated the tests.

(NOT FOR REVIEW, just for precommit testing)

Diff Detail

Unit TestsFailed

TimeTest
520 msx64 debian > Clang.OpenMP::nvptx_lambda_capturing.cpp

Event Timeline

fhahn created this revision.Jan 20 2022, 4:10 AM
Herald added a subscriber: jvesely. · View Herald TranscriptJan 20 2022, 4:10 AM
fhahn abandoned this revision.Jan 20 2022, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 5:10 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B144548: Diff 401589.Jan 20 2022, 6:45 AM

Large Diff

This large diff affects 137 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
lib/
CodeGen/
4 lines
test/
CodeGen/
8 lines
CodeGenCUDA/
2 lines
CodeGenCXX/
4 lines
8 lines
2 lines
12 lines
56 lines
36 lines
8 lines
4 lines
2 lines
2 lines
2 lines
4 lines
4 lines
12 lines
8 lines
CodeGenObjCXX/
6 lines
OpenMP/
272 lines
304 lines
64 lines
304 lines
368 lines
240 lines
368 lines
72 lines
534 lines
664 lines
664 lines
304 lines
504 lines
600 lines
600 lines
12 lines
284 lines
472 lines
120 lines
148 lines
608 lines
428 lines
20 lines
24 lines
444 lines
68 lines
32 lines
16 lines
196 lines
64 lines
374 lines
216 lines
380 lines
292 lines
376 lines
164 lines
316 lines
1398 lines
164 lines
32 lines
32 lines
96 lines
32 lines
32 lines
32 lines
32 lines
16 lines
16 lines
512 lines
304 lines
16 lines
16 lines
1042 lines
368 lines
642 lines
8 lines
32 lines
32 lines
32 lines
1580 lines
664 lines
1308 lines
12 lines
48 lines
352 lines
8 lines
96 lines
32 lines
32 lines
796 lines
600 lines
700 lines
12 lines
32 lines
32 lines
160 lines
8 lines
16 lines
16 lines
16 lines
16 lines
512 lines
304 lines
16 lines
16 lines
8 lines
16 lines
640 lines
368 lines
136 lines
416 lines
8 lines
32 lines
32 lines
32 lines
32 lines
924 lines
664 lines
248 lines
764 lines
12 lines
48 lines
352 lines
8 lines
1 line
64 lines
32 lines
32 lines
796 lines
600 lines
700 lines
1 line
12 lines
448 lines
4278 lines
16 lines
utils/
update_cc_test_checks/
Inputs/
12 lines
20 lines

Diff 401589

clang/lib/CodeGen/CGCall.cpp

clang/test/CodeGen/attr-noundef.cpp

clang/test/CodeGenCUDA/vtbl.cu

clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp

clang/test/CodeGenCXX/amdgcn-func-arg.cpp

clang/test/CodeGenCXX/arm64-constructor-return.cpp

clang/test/CodeGenCXX/attr-musttail.cpp

clang/test/CodeGenCXX/constructor-destructor-return-this.cpp

clang/test/CodeGenCXX/for-range.cpp

clang/test/CodeGenCXX/ibm128-declarations.cpp

clang/test/CodeGenCXX/matrix-casts.cpp

clang/test/CodeGenCXX/microsoft-abi-cdecl-method-sret.cpp

clang/test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp

clang/test/CodeGenCXX/microsoft-abi-extern-template.cpp

clang/test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp

clang/test/CodeGenCXX/msabi-ctor-abstract-vbase.cpp

clang/test/CodeGenCXX/pr13396.cpp

clang/test/CodeGenCXX/this-nonnull.cpp

clang/test/CodeGenObjCXX/objc-struct-cxx-abi.mm

clang/test/OpenMP/distribute_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/distribute_private_codegen.cpp

clang/test/OpenMP/distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_private_codegen.cpp

clang/test/OpenMP/distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/for_firstprivate_codegen.cpp

clang/test/OpenMP/for_lastprivate_codegen.cpp

clang/test/OpenMP/for_linear_codegen.cpp

clang/test/OpenMP/for_private_codegen.cpp

clang/test/OpenMP/for_reduction_codegen.cpp

clang/test/OpenMP/for_reduction_codegen_UDR.cpp

clang/test/OpenMP/irbuilder_for_iterator.cpp

clang/test/OpenMP/irbuilder_for_rangefor.cpp

clang/test/OpenMP/parallel_copyin_codegen.cpp

clang/test/OpenMP/parallel_for_linear_codegen.cpp

clang/test/OpenMP/parallel_master_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_private_codegen.cpp

clang/test/OpenMP/parallel_reduction_codegen.cpp

clang/test/OpenMP/sections_firstprivate_codegen.cpp

clang/test/OpenMP/sections_lastprivate_codegen.cpp

clang/test/OpenMP/sections_private_codegen.cpp

clang/test/OpenMP/sections_reduction_codegen.cpp

clang/test/OpenMP/single_codegen.cpp

clang/test/OpenMP/single_private_codegen.cpp

clang/test/OpenMP/target_parallel_codegen.cpp

clang/test/OpenMP/target_parallel_for_codegen.cpp

clang/test/OpenMP/target_parallel_for_simd_codegen.cpp

clang/test/OpenMP/target_parallel_if_codegen.cpp

clang/test/OpenMP/target_parallel_num_threads_codegen.cpp

clang/test/OpenMP/target_teams_codegen.cpp

clang/test/OpenMP/target_teams_distribute_codegen.cpp

clang/test/OpenMP/target_teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/target_teams_num_teams_codegen.cpp

clang/test/OpenMP/target_teams_thread_limit_codegen.cpp

clang/test/OpenMP/task_codegen.cpp

clang/test/OpenMP/task_member_call_codegen.cpp

clang/test/OpenMP/teams_codegen.cpp

clang/test/OpenMP/teams_distribute_codegen.cpp

clang/test/OpenMP/teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_copyin_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_private_codegen.cpp

clang/test/OpenMP/teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_aligned_messages.cpp

clang/test/OpenMP/teams_distribute_simd_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_private_messages.cpp

clang/test/OpenMP/teams_distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_private_codegen.cpp

clang/test/OpenMP/threadprivate_codegen.cpp

clang/test/OpenMP/tile_codegen.cpp

clang/test/utils/update_cc_test_checks/Inputs/basic-cplusplus.cpp.expected

clang/test/utils/update_cc_test_checks/Inputs/explicit-template-instantiation.cpp.expected