This is an archive of the discontinued LLVM Phabricator instance.

[MSAN] removing redundant tests and parameters (NFC)
ClosedPublic

Authored by kda on Jan 18 2022, 3:49 PM.

Diff Detail

Event Timeline

kda requested review of this revision.Jan 18 2022, 3:49 PM
kda created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 3:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kda updated this revision to Diff 401028.Jan 18 2022, 4:05 PM

remove "-s"

Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 4:05 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

I recommend to delay this from some time until we sure it's not going to be reverted.

vitalybuka added inline comments.Jan 27 2022, 4:56 PM
compiler-rt/test/msan/noundef_analysis.cpp
5

this one is LGTM, but better to do in a separate patch.

vitalybuka accepted this revision.Jan 27 2022, 7:02 PM
This revision is now accepted and ready to land.Jan 27 2022, 7:02 PM
kda updated this revision to Diff 457370.Sep 1 2022, 1:05 PM

rebase

Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2022, 1:05 PM
Herald added a subscriber: Enna1. · View Herald Transcript
kda retitled this revision from cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509 to [MSAN] removing redundant tests and parameters (NFC).Sep 1 2022, 1:06 PM
kda edited the summary of this revision. (Show Details)

Just returning to finish this clean up.

compiler-rt/test/msan/noundef_analysis.cpp
5

Does it fit in a general clean-up CL?

vitalybuka added inline comments.Sep 1 2022, 1:09 PM
compiler-rt/test/msan/noundef_analysis.cpp
5

yes

This revision was landed with ongoing or failed builds.Sep 1 2022, 2:04 PM
This revision was automatically updated to reflect the committed changes.