This is an archive of the discontinued LLVM Phabricator instance.

Differential D117609

[llvm-jitlink] Prevent dead-stripping of test callback
ClosedPublic

Authored by benlangmuir on Jan 18 2022, 2:29 PM.

Details

Reviewers
lhames
Commits
rGfa40c53960e2: [llvm-jitlink] Prevent dead-stripping of test callback
Summary

llvm_jitlink_setTestResultOverride is used via runtime lookup by tests, so make sure it is not dead-stripped from llvm-jitlink in release builds.




Fixes https://github.com/llvm/llvm-project/issues/5320
Diff Detail
Event Timeline
benlangmuir requested review of this revision.Jan 18 2022, 2:29 PM
benlangmuir created this revision.
Herald added a project: Restricted Project.  ·  View Herald TranscriptJan 18 2022, 2:29 PM
Herald added a subscriber: llvm-commits.  ·  View Herald Transcript
lhames accepted this revision.Jan 18 2022, 3:04 PM
LGTM. Thanks Ben!
This revision is now accepted and ready to land.Jan 18 2022, 3:04 PM
This revision was landed with ongoing or failed builds.Jan 18 2022, 3:58 PM
Closed by commit rGfa40c53960e2: [llvm-jitlink] Prevent dead-stripping of test callback (authored by benlangmuir).  ·  Explain Why
This revision was automatically updated to reflect the committed changes.
benlangmuir added a commit: rGfa40c53960e2: [llvm-jitlink] Prevent dead-stripping of test callback.
Harbormaster completed remote builds in B144117: Diff 400989.Jan 18 2022, 4:32 PM
Revision Contents
PathSize
llvm/
tools/
llvm-jitlink/
3 lines
Diff 400989
llvm/tools/llvm-jitlink/llvm-jitlink.cpp
Show First 20 Lines • Show All 225 Lines • ▼ Show 20 LinesLLVM_ATTRIBUTE_USED void linkComponents() {

  errs() << (void *)&llvm_orc_registerEHFrameSectionWrapper
  errs() << (void *)&llvm_orc_registerEHFrameSectionWrapper

         << (void *)&llvm_orc_deregisterEHFrameSectionWrapper
         << (void *)&llvm_orc_deregisterEHFrameSectionWrapper

         << (void *)&llvm_orc_registerJITLoaderGDBWrapper;
         << (void *)&llvm_orc_registerJITLoaderGDBWrapper;

}
}




static bool UseTestResultOverride = false;
static bool UseTestResultOverride = false;

static int64_t TestResultOverride = 0;
static int64_t TestResultOverride = 0;




extern "C" void llvm_jitlink_setTestResultOverride(int64_t Value) {
extern "C" LLVM_ATTRIBUTE_USED void

llvm_jitlink_setTestResultOverride(int64_t Value) {

  TestResultOverride = Value;
  TestResultOverride = Value;

  UseTestResultOverride = true;
  UseTestResultOverride = true;

}
}




static Error addSelfRelocations(LinkGraph &G);
static Error addSelfRelocations(LinkGraph &G);




namespace llvm {
namespace llvm {




▲ Show 20 Lines • Show All 1,764 Lines • Show Last 20 Lines