Page MenuHomePhabricator

[ifs] Use a tmp file instead of "-"
ClosedPublic

Authored by Jake-Egan on Jan 18 2022, 10:39 AM.

Details

Summary

Currently, Clang on AIX uses the system assembler to generate object files from assembly. The use of -o - results in a file named - instead of output to stdout. This patch uses a temporary object file instead.

Diff Detail

Event Timeline

Jake-Egan requested review of this revision.Jan 18 2022, 10:39 AM
Jake-Egan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 10:39 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jake-Egan retitled this revision from [ifs] Use a tmp file instead of - to [ifs] Use a tmp file instead of "-".Jan 18 2022, 10:40 AM
Jake-Egan edited the summary of this revision. (Show Details)
Jake-Egan added a reviewer: DiggerLin.
This revision is now accepted and ready to land.Jan 19 2022, 6:51 AM

We should update the description to reflect the cause more accurately.

hubert.reinterpretcast edited the summary of this revision. (Show Details)Jan 19 2022, 8:00 AM
hubert.reinterpretcast added inline comments.
clang/test/InterfaceStubs/object.c
2–3

With the temporary file added, the pipe is unnecessary (and possibly unwanted). Does the suggestion here work?

Jake-Egan updated this revision to Diff 401254.Jan 19 2022, 8:23 AM
Jake-Egan marked an inline comment as done.

Removed the unncessary pipe.

clang/test/InterfaceStubs/object.c
2–3

Yes this suggestion works. I updated the patch accordingly

hubert.reinterpretcast edited the summary of this revision. (Show Details)

LGTM; thanks!

This revision was automatically updated to reflect the committed changes.