[libcxx][test] `unordered_meow` iterators are not portably non-bidi

[CaseyCarter]

Summary

MSVCSTL's are actually bidirectional.

[• Quuxplusone]

We should pick one mechanism (#ifdef _MSVC_STL_VERSION or LIBCPP_STATIC_ASSERT) and stick to it. But LGTM besides that.

libcxx/test/std/containers/unord/unord.map/iterator_concept_conformance.compile.pass.cpp

30–31

Throughout: I think we should eliminate all tests for !{sized_,}sentinel_for<X, Y> where X and Y are unrelated types. Basically this file should become

static_assert(std::forward_iterator<iterator>);
LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<iterator>);
static_assert(!std::indirectly_writable<iterator, value_type>);
static_assert(std::sentinel_for<iterator, iterator>);
static_assert(std::sentinel_for<iterator, const_iterator>);
static_assert(!std::sized_sentinel_for<iterator, iterator>);
static_assert(!std::sized_sentinel_for<iterator, const_iterator>);
static_assert(std::indirectly_movable<iterator, std::pair<int, int>*>);
static_assert(!std::indirectly_movable_storable<iterator, std::pair<int, int>*>);
static_assert(!std::indirectly_swappable<iterator, iterator>);

static_assert(std::forward_iterator<const_iterator>);
LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_iterator>);
static_assert(!std::indirectly_writable<const_iterator, value_type>);
static_assert(std::sentinel_for<const_iterator, iterator>);
static_assert(std::sentinel_for<const_iterator, const_iterator>);
static_assert(!std::sized_sentinel_for<const_iterator, iterator>);
static_assert(!std::sized_sentinel_for<const_iterator, const_iterator>);
static_assert(std::indirectly_movable<const_iterator, std::pair<int, int>*>);
static_assert(!std::indirectly_movable_storable<const_iterator, std::pair<int, int>*>);
static_assert(!std::indirectly_swappable<const_iterator, const_iterator>);

and then the same set of assertions but with s/iterator/local_iterator/g. Ditto in the other test files.

libcxx/test/std/containers/unord/unord.set/iterator_concept_conformance.compile.pass.cpp

27–32

We should take the same approach here as in the other test files you're touching.

[CaseyCarter]

Address review comments.

[• Quuxplusone]

libcxx/test/std/containers/unord/unord.multimap/iterator_concept_conformance.compile.pass.cpp

66–67

Pre-existing: I suspect that the intent was to use value_type* here, not std::pair<int, int>* (and likewise value_type* in place of int* in the unordered_set tests). No action required, but if you want to fix it, go for it. (I don't think the change should affect the results of these static_asserts.)

[CaseyCarter]

libcxx/test/std/containers/unord/unord.multimap/iterator_concept_conformance.compile.pass.cpp

66–67

value_type is pair<const int, int>. *declval<pair<const int, int>*>() = ranges::iter_move(some_iterator) is never going to be a valid expression, so all of these indirectly_movable{_storable,} tests would yield false. That said, I'm not sure what value these provide - it may make sense to remove them in a followup.

[• Quuxplusone]

libcxx/test/std/containers/unord/unord.multimap/iterator_concept_conformance.compile.pass.cpp

66–67

Ah, indirectly_movable_storable (https://en.cppreference.com/w/cpp/iterator/indirectly_movable_storable) is much less sane than I had assumed. ;) I had pictured basically what you might call "indirectly_assignable_from."

The operative element in reality is that it checks std::assignable_from<std::iter_value_t<In>&, std::iter_rvalue_reference_t<In>> for the source iterator. So std::indirectly_movable_storable<unordered_map<K,V>::iterator, X> == false for all X, because std::assignable_from<unordered_map<K,V>::value_type, X> == false for all X.
So yeah, I see no value in these, and will submit a PR to remove them.

(This also suggests that the original STL chose map::value_type poorly — since set<int>::value_type is int not const int, then map<int,int>::value_type should have been pair<int,int> not pair<const int,int>. But that's water long under the bridge.)

[CaseyCarter]

libcxx/test/std/containers/unord/unord.multimap/iterator_concept_conformance.compile.pass.cpp

66–67

The intuition is "indirectly_copyable<I, O> requires *o = *i. indirectly_movable requires *o = ranges::iter_move(i). The _storable refinements require that transfer to be valid both directly, and indirectly through a variable of I's value_type via both construction and assignment.

And yes, map::value_type would be different today. There wasn't much they could have done differently in 1998 if they wanted to forbid changing map keys via iterator references - remember that Cpp17ForwardIterator must have a reference type of value_type& or const value_type&.

libcxx/test/std/containers/unord/unord.map/iterator_concept_conformance.compile.pass.cpp

 // UNSUPPORTED: libcpp-no-concepts
 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_map>
 
 #include <iterator>
 
+#include "test_macros.h"
+
 using iterator = std::unordered_map<int, int>::iterator;
 using const_iterator = std::unordered_map<int, int>::const_iterator;
 using local_iterator = std::unordered_map<int, int>::local_iterator;
 using const_local_iterator = std::unordered_map<int, int>::const_local_iterator;
 using value_type = std::pair<const int, int>;
 
 static_assert(std::forward_iterator<iterator>);
-static_assert(!std::bidirectional_iterator<iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<iterator>);
 static_assert(!std::indirectly_writable<iterator, value_type>);
 static_assert(std::sentinel_for<iterator, iterator>);
 static_assert(std::sentinel_for<iterator, const_iterator>);
-static_assert(!std::sentinel_for<iterator, local_iterator>);
-static_assert(!std::sentinel_for<iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<iterator, iterator>);
 static_assert(!std::sized_sentinel_for<iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_movable_storable<iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<iterator, iterator>);
 
 static_assert(std::forward_iterator<const_iterator>);
-static_assert(!std::bidirectional_iterator<const_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_iterator>);
 static_assert(!std::indirectly_writable<const_iterator, value_type>);
 static_assert(std::sentinel_for<const_iterator, iterator>);
 static_assert(std::sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sentinel_for<const_iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_iterator, std::pair<int, int>*>);
+static_assert(!std::indirectly_movable_storable<const_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<const_iterator, const_iterator>);
 
 static_assert(std::forward_iterator<local_iterator>);
-static_assert(!std::bidirectional_iterator<local_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<local_iterator>);
 static_assert(!std::indirectly_writable<local_iterator, value_type>);
-static_assert(!std::sentinel_for<local_iterator, iterator>);
-static_assert(!std::sentinel_for<local_iterator, const_iterator>);
 static_assert(std::sentinel_for<local_iterator, local_iterator>);
 static_assert(std::sentinel_for<local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<local_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_movable_storable<local_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<local_iterator, local_iterator>);
 
 static_assert(std::forward_iterator<const_local_iterator>);
-static_assert(!std::bidirectional_iterator<const_local_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_local_iterator>);
 static_assert(!std::indirectly_writable<const_local_iterator, value_type>);
-static_assert(!std::sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sentinel_for<const_local_iterator, const_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, local_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_local_iterator, std::pair<int, int>*>);
+static_assert(!std::indirectly_movable_storable<const_local_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<const_local_iterator, const_local_iterator>);

libcxx/test/std/containers/unord/unord.map/range_concept_conformance.compile.pass.cpp

 
 // unordered_map
 
 #include <unordered_map>
 
 #include <concepts>
 #include <ranges>
 
+#include "test_macros.h"
+
 using range = std::unordered_map<int, int>;
 
 
 static_assert(std::same_as<std::ranges::iterator_t<range>, range::iterator>);
 static_assert(std::ranges::common_range<range>);
 static_assert(std::ranges::forward_range<range>);
-static_assert(!std::ranges::bidirectional_range<range>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range>);
 static_assert(!std::ranges::view<range>);
 static_assert(std::ranges::sized_range<range>);
 static_assert(!std::ranges::borrowed_range<range>);
 static_assert(std::ranges::viewable_range<range>);
 
 static_assert(std::same_as<std::ranges::iterator_t<range const>, range::const_iterator>);
 static_assert(std::ranges::common_range<range const>);
 static_assert(std::ranges::forward_range<range const>);
-static_assert(!std::ranges::bidirectional_range<range const>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range const>);
 static_assert(!std::ranges::view<range const>);
 static_assert(std::ranges::sized_range<range const>);
 static_assert(!std::ranges::borrowed_range<range const>);
 static_assert(!std::ranges::viewable_range<range const>);

libcxx/test/std/containers/unord/unord.multimap/iterator_concept_conformance.compile.pass.cpp

 // UNSUPPORTED: libcpp-no-concepts
 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_map>
 
 #include <iterator>
 
+#include "test_macros.h"
+
 using iterator = std::unordered_multimap<int, int>::iterator;
 using const_iterator = std::unordered_multimap<int, int>::const_iterator;
 using local_iterator = std::unordered_multimap<int, int>::local_iterator;
 using const_local_iterator = std::unordered_multimap<int, int>::const_local_iterator;
 using value_type = std::pair<const int, int>;
 
 static_assert(std::forward_iterator<iterator>);
-static_assert(!std::bidirectional_iterator<iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<iterator>);
 static_assert(!std::indirectly_writable<iterator, value_type>);
 static_assert(std::sentinel_for<iterator, iterator>);
 static_assert(std::sentinel_for<iterator, const_iterator>);
-static_assert(!std::sentinel_for<iterator, local_iterator>);
-static_assert(!std::sentinel_for<iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<iterator, iterator>);
 static_assert(!std::sized_sentinel_for<iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_movable_storable<iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<iterator, iterator>);
 
 static_assert(std::forward_iterator<const_iterator>);
-static_assert(!std::bidirectional_iterator<const_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_iterator>);
 static_assert(!std::indirectly_writable<const_iterator, value_type>);
 static_assert(std::sentinel_for<const_iterator, iterator>);
 static_assert(std::sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sentinel_for<const_iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_iterator, std::pair<int, int>*>);
+static_assert(!std::indirectly_movable_storable<const_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<const_iterator, const_iterator>);
 
 static_assert(std::forward_iterator<local_iterator>);
-static_assert(!std::bidirectional_iterator<local_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<local_iterator>);
 static_assert(!std::indirectly_writable<local_iterator, value_type>);
-static_assert(!std::sentinel_for<local_iterator, iterator>);
-static_assert(!std::sentinel_for<local_iterator, const_iterator>);
 static_assert(std::sentinel_for<local_iterator, local_iterator>);
 static_assert(std::sentinel_for<local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<local_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_movable_storable<local_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<local_iterator, local_iterator>);
 
 static_assert(std::forward_iterator<const_local_iterator>);
-static_assert(!std::bidirectional_iterator<const_local_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_local_iterator>);
 static_assert(!std::indirectly_writable<const_local_iterator, value_type>);
-static_assert(!std::sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sentinel_for<const_local_iterator, const_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, local_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_local_iterator, std::pair<int, int>*>);
+static_assert(!std::indirectly_movable_storable<const_local_iterator, std::pair<int, int>*>);
 static_assert(!std::indirectly_swappable<const_local_iterator, const_local_iterator>);

libcxx/test/std/containers/unord/unord.multimap/range_concept_conformance.compile.pass.cpp

 
 // unordered_multimap
 
 #include <unordered_map>
 
 #include <concepts>
 #include <ranges>
 
+#include "test_macros.h"
+
 using range = std::unordered_multimap<int, int>;
 
 
 static_assert(std::same_as<std::ranges::iterator_t<range>, range::iterator>);
 static_assert(std::ranges::common_range<range>);
 static_assert(std::ranges::forward_range<range>);
-static_assert(!std::ranges::bidirectional_range<range>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range>);
 static_assert(!std::ranges::view<range>);
 static_assert(std::ranges::sized_range<range>);
 static_assert(!std::ranges::borrowed_range<range>);
 static_assert(std::ranges::viewable_range<range>);
 
 static_assert(std::same_as<std::ranges::iterator_t<range const>, range::const_iterator>);
 static_assert(std::ranges::common_range<range const>);
 static_assert(std::ranges::forward_range<range const>);
-static_assert(!std::ranges::bidirectional_range<range const>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range const>);
 static_assert(!std::ranges::view<range const>);
 static_assert(std::ranges::sized_range<range const>);
 static_assert(!std::ranges::borrowed_range<range const>);
 static_assert(!std::ranges::viewable_range<range const>);

libcxx/test/std/containers/unord/unord.multiset/iterator_concept_conformance.compile.pass.cpp

 // UNSUPPORTED: libcpp-no-concepts
 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_set>
 
 #include <iterator>
 
+#include "test_macros.h"
+
 using iterator = std::unordered_multiset<int>::iterator;
 using const_iterator = std::unordered_multiset<int>::const_iterator;
 using local_iterator = std::unordered_multiset<int>::local_iterator;
 using const_local_iterator = std::unordered_multiset<int>::const_local_iterator;
 using value_type = int;
 
 static_assert(std::forward_iterator<iterator>);
-static_assert(!std::bidirectional_iterator<iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<iterator>);
 static_assert(!std::indirectly_writable<iterator, value_type>);
 static_assert(std::sentinel_for<iterator, iterator>);
 static_assert(std::sentinel_for<iterator, const_iterator>);
-static_assert(!std::sentinel_for<iterator, local_iterator>);
-static_assert(!std::sentinel_for<iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<iterator, iterator>);
 static_assert(!std::sized_sentinel_for<iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<iterator, int*>);
 static_assert(std::indirectly_movable_storable<iterator, int*>);
 static_assert(!std::indirectly_swappable<iterator, iterator>);
 
 static_assert(std::forward_iterator<const_iterator>);
-static_assert(!std::bidirectional_iterator<const_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_iterator>);
 static_assert(!std::indirectly_writable<const_iterator, value_type>);
 static_assert(std::sentinel_for<const_iterator, iterator>);
 static_assert(std::sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sentinel_for<const_iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_iterator, int*>);
+static_assert(std::indirectly_movable_storable<const_iterator, int*>);
 static_assert(!std::indirectly_swappable<const_iterator, const_iterator>);
 
 static_assert(std::forward_iterator<local_iterator>);
-static_assert(!std::bidirectional_iterator<local_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<local_iterator>);
 static_assert(!std::indirectly_writable<local_iterator, value_type>);
-static_assert(!std::sentinel_for<local_iterator, iterator>);
-static_assert(!std::sentinel_for<local_iterator, const_iterator>);
 static_assert(std::sentinel_for<local_iterator, local_iterator>);
 static_assert(std::sentinel_for<local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<local_iterator, int*>);
 static_assert(std::indirectly_movable_storable<local_iterator, int*>);
 static_assert(!std::indirectly_swappable<local_iterator, local_iterator>);
 
 static_assert(std::forward_iterator<const_local_iterator>);
-static_assert(!std::bidirectional_iterator<const_local_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_local_iterator>);
 static_assert(!std::indirectly_writable<const_local_iterator, value_type>);
-static_assert(!std::sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sentinel_for<const_local_iterator, const_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, local_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_local_iterator, int*>);
+static_assert(std::indirectly_movable_storable<const_local_iterator, int*>);
 static_assert(!std::indirectly_swappable<const_local_iterator, const_local_iterator>);

libcxx/test/std/containers/unord/unord.multiset/range_concept_conformance.compile.pass.cpp

 
 // unordered_multiset
 
 #include <unordered_set>
 
 #include <concepts>
 #include <ranges>
 
+#include "test_macros.h"
+
 using range = std::unordered_multiset<int>;
 
 
 static_assert(std::same_as<std::ranges::iterator_t<range>, range::iterator>);
 static_assert(std::ranges::common_range<range>);
 static_assert(std::ranges::forward_range<range>);
-static_assert(!std::ranges::bidirectional_range<range>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range>);
 static_assert(!std::ranges::view<range>);
 static_assert(std::ranges::sized_range<range>);
 static_assert(!std::ranges::borrowed_range<range>);
 static_assert(std::ranges::viewable_range<range>);
 
 static_assert(std::same_as<std::ranges::iterator_t<range const>, range::const_iterator>);
 static_assert(std::ranges::common_range<range const>);
 static_assert(std::ranges::forward_range<range const>);
-static_assert(!std::ranges::bidirectional_range<range const>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range const>);
 static_assert(!std::ranges::view<range const>);
 static_assert(std::ranges::sized_range<range const>);
 static_assert(!std::ranges::borrowed_range<range const>);
 static_assert(!std::ranges::viewable_range<range const>);

libcxx/test/std/containers/unord/unord.set/iterator_concept_conformance.compile.pass.cpp

 // UNSUPPORTED: libcpp-no-concepts
 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_set>
 
 #include <iterator>
 
+#include "test_macros.h"
+
 using iterator = std::unordered_set<int>::iterator;
 using const_iterator = std::unordered_set<int>::const_iterator;
 using local_iterator = std::unordered_set<int>::local_iterator;
 using const_local_iterator = std::unordered_set<int>::const_local_iterator;
 using value_type = int;
 
 static_assert(std::forward_iterator<iterator>);
-static_assert(!std::bidirectional_iterator<iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<iterator>);
 static_assert(!std::indirectly_writable<iterator, value_type>);
 static_assert(std::sentinel_for<iterator, iterator>);
 static_assert(std::sentinel_for<iterator, const_iterator>);
-static_assert(!std::sentinel_for<iterator, local_iterator>);
-static_assert(!std::sentinel_for<iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<iterator, iterator>);
 static_assert(!std::sized_sentinel_for<iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<iterator, int*>);
 static_assert(std::indirectly_movable_storable<iterator, int*>);
 static_assert(!std::indirectly_swappable<iterator, iterator>);
 
 static_assert(std::forward_iterator<const_iterator>);
-static_assert(!std::bidirectional_iterator<const_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_iterator>);
 static_assert(!std::indirectly_writable<const_iterator, value_type>);
 static_assert(std::sentinel_for<const_iterator, iterator>);
 static_assert(std::sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sentinel_for<const_iterator, const_local_iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, iterator>);
 static_assert(!std::sized_sentinel_for<const_iterator, const_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, local_iterator>);
-static_assert(!std::sized_sentinel_for<const_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_iterator, int*>);
+static_assert(std::indirectly_movable_storable<const_iterator, int*>);
 static_assert(!std::indirectly_swappable<const_iterator, const_iterator>);
 
 static_assert(std::forward_iterator<local_iterator>);
-static_assert(!std::bidirectional_iterator<local_iterator>);
-static_assert(!std::sentinel_for<local_iterator, iterator>);
-static_assert(!std::sentinel_for<local_iterator, const_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<local_iterator>);
 static_assert(std::sentinel_for<local_iterator, local_iterator>);
 static_assert(std::sentinel_for<local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<local_iterator, const_local_iterator>);
 static_assert(std::indirectly_movable<local_iterator, int*>);
 static_assert(std::indirectly_movable_storable<local_iterator, int*>);
 static_assert(!std::indirectly_swappable<local_iterator, local_iterator>);
 
 static_assert(std::forward_iterator<const_local_iterator>);
-static_assert(!std::bidirectional_iterator<const_local_iterator>);
+LIBCPP_STATIC_ASSERT(!std::bidirectional_iterator<const_local_iterator>);
 static_assert(!std::indirectly_writable<const_local_iterator, value_type>);
-static_assert(!std::sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sentinel_for<const_local_iterator, const_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, local_iterator>);
 static_assert(std::sentinel_for<const_local_iterator, const_local_iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, iterator>);
-static_assert(!std::sized_sentinel_for<const_local_iterator, const_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, local_iterator>);
 static_assert(!std::sized_sentinel_for<const_local_iterator, const_local_iterator>);
+static_assert(std::indirectly_movable<const_local_iterator, int*>);
+static_assert(std::indirectly_movable_storable<const_local_iterator, int*>);
 static_assert(!std::indirectly_swappable<const_local_iterator, const_local_iterator>);

libcxx/test/std/containers/unord/unord.set/range_concept_conformance.compile.pass.cpp

 
 // unordered_multiset
 
 #include <unordered_set>
 
 #include <concepts>
 #include <ranges>
 
+#include "test_macros.h"
+
 using range = std::unordered_set<int>;
 
 
 static_assert(std::same_as<std::ranges::iterator_t<range>, range::iterator>);
 static_assert(std::ranges::common_range<range>);
 static_assert(std::ranges::forward_range<range>);
-static_assert(!std::ranges::bidirectional_range<range>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range>);
 static_assert(!std::ranges::view<range>);
 static_assert(std::ranges::sized_range<range>);
 static_assert(!std::ranges::borrowed_range<range>);
 static_assert(std::ranges::viewable_range<range>);
 
 static_assert(std::same_as<std::ranges::iterator_t<range const>, range::const_iterator>);
 static_assert(std::ranges::common_range<range const>);
 static_assert(std::ranges::forward_range<range const>);
-static_assert(!std::ranges::bidirectional_range<range const>);
+LIBCPP_STATIC_ASSERT(!std::ranges::bidirectional_range<range const>);
 static_assert(!std::ranges::view<range const>);
 static_assert(std::ranges::sized_range<range const>);
 static_assert(!std::ranges::borrowed_range<range const>);
 static_assert(!std::ranges::viewable_range<range const>);