Page MenuHomePhabricator

[clang] Remap file path in __PRETTY_FUNCTION__
Needs ReviewPublic

Authored by jyyou.tw on Jan 14 2022, 7:51 AM.

Details

Reviewers
rsmith
Summary

PRETTY_FUNCTION may have file path in template argument
but -fmacro-prefix-map can't remap it. This patch tries to fix the problem.

Diff Detail

Event Timeline

jyyou.tw requested review of this revision.Jan 14 2022, 7:51 AM
jyyou.tw created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2022, 7:51 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

This seems like patching a hole, but maybe something more fundamental should be done if this remapping is meant to apply to all path rendering? (presumably there could be other bugs where these callbacks aren't applied - so is there somewhere lower level that this issue could be fixed that'd make any other callsites like this safe/correct?)

keith added a subscriber: keith.Feb 4 2022, 10:47 PM