This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][darwin] check for strcmp to test interceptors instead of pthread_create
ClosedPublic

Authored by aralisza on Jan 10 2022, 7:29 PM.

Details

Summary

If pthread_create is not available on a platform, we won't be able to check if interceptors work. Use strcmp instead.

Diff Detail

Event Timeline

aralisza created this revision.Jan 10 2022, 7:29 PM
aralisza requested review of this revision.Jan 10 2022, 7:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2022, 7:29 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
aralisza planned changes to this revision.Jan 10 2022, 7:34 PM
aralisza updated this revision to Diff 398816.Jan 10 2022, 7:38 PM

use strcmp

aralisza retitled this revision from [compiler-rt][darwin] check for dlsym to test interceptors instead of pthread_create to [compiler-rt][darwin] check for strcmp to test interceptors instead of pthread_create.Jan 10 2022, 7:38 PM
aralisza edited the summary of this revision. (Show Details)
aralisza edited the summary of this revision. (Show Details)
aralisza updated this revision to Diff 399072.Jan 11 2022, 2:01 PM

remove internal_

yln accepted this revision.Jan 11 2022, 2:05 PM
This revision is now accepted and ready to land.Jan 11 2022, 2:05 PM