Page MenuHomePhabricator

[Clang] Extract availability mapping from VersionMap for watchOS/tvOS
ClosedPublic

Authored by egorzhdan on Jan 4 2022, 12:00 PM.

Details

Summary

This change makes it possible to extract iOS-to-another-platform version mappings from VersionMap in the SDKSettings.json file in Darwin SDKs, for example, iOS_watchOS and iOS_tvOS.

This code was originally authored by Alex Lorenz.

rdar://81491680

Diff Detail

Event Timeline

egorzhdan created this revision.Jan 4 2022, 12:00 PM
egorzhdan requested review of this revision.Jan 4 2022, 12:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2022, 12:00 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Thanks! I think your tests don't actually test the added code, can you check if you can parse a mapping like ios_tvos in the constructed SDK settings?

egorzhdan updated this revision to Diff 397541.Jan 5 2022, 5:17 AM

Add a test to verify that iOS_tvOS mapping is parsed correctly.

egorzhdan updated this revision to Diff 397565.Jan 5 2022, 7:15 AM

Fix lint warning

arphaman accepted this revision.Jan 5 2022, 9:20 AM

LGTM

This revision is now accepted and ready to land.Jan 5 2022, 9:20 AM
This revision was landed with ongoing or failed builds.Jan 5 2022, 5:00 PM
This revision was automatically updated to reflect the committed changes.