[Clang] Extract availability mapping from VersionMap for watchOS/tvOS
ClosedPublic
Actions

Authored by egorzhdan on Jan 4 2022, 12:00 PM.

Details

Reviewers

arphaman

Commits

rG809c6a5a1d2f: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

Summary

This change makes it possible to extract iOS-to-another-platform version mappings from VersionMap in the SDKSettings.json file in Darwin SDKs, for example, iOS_watchOS and iOS_tvOS.

This code was originally authored by Alex Lorenz.

rdar://81491680

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

egorzhdan created this revision.Jan 4 2022, 12:00 PM

Herald added a subscriber: dexonsmith. · View Herald TranscriptJan 4 2022, 12:00 PM

egorzhdan requested review of this revision.Jan 4 2022, 12:00 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2022, 12:00 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

egorzhdan added a reviewer: arphaman.Jan 4 2022, 12:01 PM

Harbormaster completed remote builds in B141540: Diff 397366.Jan 4 2022, 12:30 PM

Thanks! I think your tests don't actually test the added code, can you check if you can parse a mapping like ios_tvos in the constructed SDK settings?

Add a test to verify that iOS_tvOS mapping is parsed correctly.

Harbormaster completed remote builds in B141656: Diff 397541.Jan 5 2022, 5:51 AM

Fix lint warning

Harbormaster completed remote builds in B141673: Diff 397565.Jan 5 2022, 7:48 AM

LGTM

This revision is now accepted and ready to land.Jan 5 2022, 9:20 AM

This revision was landed with ongoing or failed builds.Jan 5 2022, 5:00 PM

Closed by commit rG809c6a5a1d2f: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS (authored by egorzhdan, committed by arphaman). · Explain Why

This revision was automatically updated to reflect the committed changes.

arphaman added a commit: rG809c6a5a1d2f: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.