Use the zx_clock_get_monotonic system call directly rather than
going through the POSIX clock_gettime function. The libc function
is a trivial wrapper around the system call, and is not a standard C
function. Avoiding it reduces the Fuchsia libc ABI surface that
libc++ depends on.
Details
Details
- Reviewers
phosek ldionne - Group Reviewers
Restricted Project - Commits
- rGce167c6fb2ae: [libcxx] Use Fuchsia-native monotonic clock for std::chrono::steady_clock
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM
libcxx/src/chrono.cpp | ||
---|---|---|
273–284 | The rest of this file doesn't seem to be using this indentation. |
libcxx/src/chrono.cpp | ||
---|---|---|
273–284 | AFAICT it's not consistent within the file. There are spaces after # in the some of the blocks at the top but not everywhere else. |
Comment Actions
Ping. This is very similar to the other change I landed recently. It needs approval from a libc++ maintainer.
Thanks.
The rest of this file doesn't seem to be using this indentation.