This is an archive of the discontinued LLVM Phabricator instance.

Differential D116509

[Builtins] Add missing the macro 'y' description in comments
ClosedPublic

Authored by Jim on Jan 2 2022, 5:28 PM.

Details

Reviewers
stuij
Commits
rG9b70ddaff6e1: [Builtins] Add missing the macro 'y' description in comments

Diff Detail

Unit TestsFailed

TimeTest
60 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

Jim requested review of this revision.Jan 2 2022, 5:28 PM
Jim created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2022, 5:28 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jim added a reviewer: stuij.Jan 2 2022, 5:29 PM
Harbormaster completed remote builds in B141260: Diff 396968.Jan 2 2022, 6:04 PM
stuij accepted this revision.Jan 7 2022, 7:37 AM

LGTM, thanks!

Nit: perhaps make the commit message a little bit clearer.

This revision is now accepted and ready to land.Jan 7 2022, 7:37 AM
This revision was landed with ongoing or failed builds.Jan 9 2022, 6:47 PM
Closed by commit rG9b70ddaff6e1: [Builtins] Add missing the macro 'y' description in comments (authored by Jim). · Explain Why
This revision was automatically updated to reflect the committed changes.
Jim added a commit: rG9b70ddaff6e1: [Builtins] Add missing the macro 'y' description in comments.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
1 line

Diff 396968

clang/include/clang/Basic/Builtins.def

Show All 20 Lines
// (result value, then each argument) as follows: // (result value, then each argument) as follows:
// v -> void // v -> void
// b -> boolean // b -> boolean
// c -> char // c -> char
// s -> short // s -> short
// i -> int // i -> int
// h -> half (__fp16, OpenCL) // h -> half (__fp16, OpenCL)
// x -> half (_Float16) // x -> half (_Float16)
// y -> half (__bf16)
// f -> float // f -> float
// d -> double // d -> double
// z -> size_t // z -> size_t
// w -> wchar_t // w -> wchar_t
// F -> constant CFString // F -> constant CFString
// G -> id // G -> id
// H -> SEL // H -> SEL
// M -> struct objc_super // M -> struct objc_super
▲ Show 20 Lines • Show All 1,650 Lines • Show Last 20 Lines