This is an archive of the discontinued LLVM Phabricator instance.

Differential D116335

Make lld to support win-xp
AbandonedPublic

Authored by gmh5225 on Dec 28 2021, 8:40 AM.

Details

Reviewers
01169957911
01alchemist
0b01
0x1eaf
0x59616e
Summary

Support winxp by modifying coff structure and xml.
I don't have commit access.

Diff Detail

Event Timeline

gmh5225 requested review of this revision.Dec 28 2021, 8:40 AM
gmh5225 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2021, 8:40 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B140794: Diff 396397.Dec 28 2021, 8:41 AM
gmh5225 updated this revision to Diff 396407.Dec 28 2021, 9:40 AM

Re-upload diff

Harbormaster completed remote builds in B140800: Diff 396407.Dec 28 2021, 10:05 AM
gmh5225 updated this revision to Diff 396443.Dec 28 2021, 4:28 PM

Fix test and re-upload.

Harbormaster completed remote builds in B140826: Diff 396443.Dec 28 2021, 4:38 PM
gmh5225 updated this revision to Diff 396459.Dec 28 2021, 7:54 PM

Fix test manifest

Harbormaster completed remote builds in B140838: Diff 396459.Dec 28 2021, 7:55 PM
gmh5225 updated this revision to Diff 396463.Dec 28 2021, 9:36 PM

fix subsystem.test

Harbormaster completed remote builds in B140840: Diff 396463.Dec 28 2021, 9:37 PM
gmh5225 updated this revision to Diff 396464.Dec 28 2021, 9:44 PM

Fix subsystem.test

Harbormaster completed remote builds in B140841: Diff 396464.Dec 28 2021, 9:45 PM
gmh5225 abandoned this revision.Dec 29 2021, 5:02 AM

Revision Contents

PathSize
lld/
COFF/
6 lines
9 lines

Diff 396407

lld/COFF/Config.h

Context not available.
uint32_t minorImageVersion = 0; uint32_t minorImageVersion = 0;
// If changing the default os/subsys version here, update the default in // If changing the default os/subsys version here, update the default in
// the MinGW driver accordingly. // the MinGW driver accordingly.
uint32_t majorOSVersion = 6; // Chang the value to 4 to support win-xp
uint32_t majorOSVersion = 4;
uint32_t minorOSVersion = 0; uint32_t minorOSVersion = 0;
uint32_t majorSubsystemVersion = 6; // Chang the value to 4 to support win-xp
uint32_t majorSubsystemVersion = 4;
uint32_t minorSubsystemVersion = 0; uint32_t minorSubsystemVersion = 0;
uint32_t timestamp = 0; uint32_t timestamp = 0;
uint32_t functionPadMin = 0; uint32_t functionPadMin = 0;
Context not available.

lld/COFF/DriverUtils.cpp

Context not available.
// Emit the XML. Note that we do *not* verify that the XML attributes are // Emit the XML. Note that we do *not* verify that the XML attributes are
// syntactically correct. This is intentional for link.exe compatibility. // syntactically correct. This is intentional for link.exe compatibility.
os << "<?xml version=\"1.0\" standalone=\"yes\"?>\n" // Use microsoft xml to support win-xp.
<< "<assembly xmlns=\"urn:schemas-microsoft-com:asm.v1\"\n" os << "<?xml version='1.0' encoding='UTF-8' standalone='yes'?>\n"
<< " manifestVersion=\"1.0\">\n"; << "<assembly xmlns='urn:schemas-microsoft-com:asm.v1' "
"manifestVersion='1.0'>\n";
if (config->manifestUAC) { if (config->manifestUAC) {
os << " <trustInfo>\n" os << " <trustInfo xmlns=\"urn:schemas-microsoft-com:asm.v3\">\n"
<< " <security>\n" << " <security>\n"
<< " <requestedPrivileges>\n" << " <requestedPrivileges>\n"
<< " <requestedExecutionLevel level=" << config->manifestLevel << " <requestedExecutionLevel level=" << config->manifestLevel
Context not available.