This is an archive of the discontinued LLVM Phabricator instance.

[libc++][ranges][NFC] Remove extraneous cleanup checks.
ClosedPublic

Authored by var-const on Dec 15 2021, 7:21 PM.

Details

Summary

There is no need to check the counters on Counted after destroying
elements in the range because these tests are not testing destroy.

Diff Detail

Event Timeline

var-const requested review of this revision.Dec 15 2021, 7:21 PM
var-const created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2021, 7:21 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Quuxplusone added a subscriber: Quuxplusone.

Seems harmless to keep, but also harmless to remove. :)

ldionne accepted this revision.Dec 16 2021, 9:13 AM
ldionne added a subscriber: ldionne.

Seems harmless to keep, but also harmless to remove. :)

I requested that in another review. IMO it's better to remove cause it removes the possibility for confusion around what we're trying to test.

This revision is now accepted and ready to land.Dec 16 2021, 9:13 AM

Note that the only CI failures are on Windows and they look infra-related. Feel free to ship this.

This revision was landed with ongoing or failed builds.Dec 16 2021, 2:48 PM
This revision was automatically updated to reflect the committed changes.