This is an archive of the discontinued LLVM Phabricator instance.

Differential D115809

[ASTMatchers] Make ParamIndex unsigned.
ClosedPublic

Authored by flx on Dec 15 2021, 10:37 AM.

Details

Reviewers
sammccall
Commits
rG54ed30fdd63b: [ASTMatchers] Make ParamIndex unsigned.
Summary

This fixes a compiler error/warning in
https://lab.llvm.org/buildbot/#/builders/36/builds/15377.

Diff Detail

Event Timeline

flx created this revision.Dec 15 2021, 10:37 AM
Herald added a subscriber: arphaman. · View Herald TranscriptDec 15 2021, 10:37 AM
flx requested review of this revision.Dec 15 2021, 10:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2021, 10:37 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sammccall accepted this revision.Dec 15 2021, 10:46 AM

LG, thanks!

This revision is now accepted and ready to land.Dec 15 2021, 10:46 AM
This revision was landed with ongoing or failed builds.Dec 15 2021, 10:49 AM
Closed by commit rG54ed30fdd63b: [ASTMatchers] Make ParamIndex unsigned. (authored by flx). · Explain Why
This revision was automatically updated to reflect the committed changes.
flx added a commit: rG54ed30fdd63b: [ASTMatchers] Make ParamIndex unsigned..
Harbormaster completed remote builds in B139467: Diff 394602.Dec 15 2021, 11:08 AM
flx mentioned this in D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType..Dec 15 2021, 11:19 AM

Revision Contents

PathSize
clang/
include/
clang/
ASTMatchers/
2 lines

Diff 394605

clang/include/clang/ASTMatchers/ASTMatchers.h

Show First 20 Lines • Show All 4,866 Lines • ▼ Show 20 Lines if (const auto *Value =
FProto = MP->getPointeeType()->getAs<FunctionProtoType>(); FProto = MP->getPointeeType()->getAs<FunctionProtoType>();
assert(FProto && assert(FProto &&
"The call must have happened through a member function " "The call must have happened through a member function "
"pointer"); "pointer");
} }
} }
} }
int ParamIndex = 0; unsigned ParamIndex = 0;
bool Matched = false; bool Matched = false;
unsigned NumArgs = Node.getNumArgs(); unsigned NumArgs = Node.getNumArgs();
if (FProto && FProto->isVariadic()) if (FProto && FProto->isVariadic())
NumArgs = std::min(NumArgs, FProto->getNumParams()); NumArgs = std::min(NumArgs, FProto->getNumParams());
for (; ArgIndex < NumArgs; ++ArgIndex, ++ParamIndex) { for (; ArgIndex < NumArgs; ++ArgIndex, ++ParamIndex) {
BoundNodesTreeBuilder ArgMatches(*Builder); BoundNodesTreeBuilder ArgMatches(*Builder);
if (ArgMatcher.matches(*(Node.getArg(ArgIndex)->IgnoreParenCasts()), Finder, if (ArgMatcher.matches(*(Node.getArg(ArgIndex)->IgnoreParenCasts()), Finder,
▲ Show 20 Lines • Show All 3,411 Lines • Show Last 20 Lines