This is an archive of the discontinued LLVM Phabricator instance.

Differential D115733

[benchmark] Delete BUILD files
ClosedPublic

Authored by mtrofin on Dec 14 2021, 8:09 AM.

Details

Reviewers
gribozavr2
lebedev.ri
Commits
rG48d868493fa7: [benchmark] Delete BUILD files
Summary

Bazel support is through utils/bazel, and the BUILD files in benchmark
just complicate downstream integrates for bazel based builds.

Diff Detail

Event Timeline

mtrofin created this revision.Dec 14 2021, 8:09 AM
Herald added a reviewer: lebedev.ri. · View Herald TranscriptDec 14 2021, 8:09 AM
Herald added a subscriber: lebedev.ri. · View Herald Transcript
mtrofin requested review of this revision.Dec 14 2021, 8:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2021, 8:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
gribozavr2 accepted this revision.Dec 14 2021, 8:10 AM

Could you also delete BUILD.bazel files?

This revision is now accepted and ready to land.Dec 14 2021, 8:10 AM
mtrofin updated this revision to Diff 394263.Dec 14 2021, 8:12 AM

also BUILD.bazel

This revision was landed with ongoing or failed builds.Dec 14 2021, 8:13 AM
Closed by commit rG48d868493fa7: [benchmark] Delete BUILD files (authored by mtrofin). · Explain Why
This revision was automatically updated to reflect the committed changes.
mtrofin added a commit: rG48d868493fa7: [benchmark] Delete BUILD files.
Harbormaster completed remote builds in B139232: Diff 394263.Dec 14 2021, 9:42 AM

Revision Contents

PathSize
third-party/
benchmark/
bindings/
python/
google_benchmark/
test/
tools/
2 lines

Diff 394264

third-party/benchmark/BUILD.bazel

  • This file was deleted.
licenses(["notice"])
config_setting(
name = "qnx",
constraint_values = ["@platforms//os:qnx"],
values = {
"cpu": "x64_qnx",
},
visibility = [":__subpackages__"],
)
config_setting(
name = "windows",
constraint_values = ["@platforms//os:windows"],
values = {
"cpu": "x64_windows",
},
visibility = [":__subpackages__"],
)
cc_library(
name = "benchmark",
srcs = glob(
[
"src/*.cc",
"src/*.h",
],
exclude = ["src/benchmark_main.cc"],
),
hdrs = ["include/benchmark/benchmark.h"],
linkopts = select({
":windows": ["-DEFAULTLIB:shlwapi.lib"],
"//conditions:default": ["-pthread"],
}),
strip_include_prefix = "include",
visibility = ["//visibility:public"],
)
cc_library(
name = "benchmark_main",
srcs = ["src/benchmark_main.cc"],
hdrs = ["include/benchmark/benchmark.h"],
strip_include_prefix = "include",
visibility = ["//visibility:public"],
deps = [":benchmark"],
)
cc_library(
name = "benchmark_internal_headers",
hdrs = glob(["src/*.h"]),
visibility = ["//test:__pkg__"],
)

third-party/benchmark/bindings/python/BUILD

  • This file was deleted.
exports_files(glob(["*.BUILD"]))
exports_files(["build_defs.bzl"])

third-party/benchmark/bindings/python/google_benchmark/BUILD

  • This file was deleted.
load("//bindings/python:build_defs.bzl", "py_extension")
py_library(
name = "google_benchmark",
srcs = ["__init__.py"],
visibility = ["//visibility:public"],
deps = [
":_benchmark",
# pip; absl:app
],
)
py_extension(
name = "_benchmark",
srcs = ["benchmark.cc"],
copts = [
"-fexceptions",
"-fno-strict-aliasing",
],
features = ["-use_header_modules"],
deps = [
"//:benchmark",
"@pybind11",
"@python_headers",
],
)
py_test(
name = "example",
srcs = ["example.py"],
python_version = "PY3",
srcs_version = "PY3",
visibility = ["//visibility:public"],
deps = [
":google_benchmark",
],
)

third-party/benchmark/test/BUILD

  • This file was deleted.
TEST_COPTS = [
"-pedantic",
"-pedantic-errors",
"-std=c++11",
"-Wall",
"-Wextra",
"-Wshadow",
# "-Wshorten-64-to-32",
"-Wfloat-equal",
"-fstrict-aliasing",
]
PER_SRC_COPTS = ({
"cxx03_test.cc": ["-std=c++03"],
# Some of the issues with DoNotOptimize only occur when optimization is enabled
"donotoptimize_test.cc": ["-O3"],
})
TEST_ARGS = ["--benchmark_min_time=0.01"]
PER_SRC_TEST_ARGS = ({
"user_counters_tabular_test.cc": ["--benchmark_counters_tabular=true"],
"repetitions_test.cc": [" --benchmark_repetitions=3"],
"spec_arg_test.cc" : ["--benchmark_filter=BM_NotChosen"],
})
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
cc_library(
name = "output_test_helper",
testonly = 1,
srcs = ["output_test_helper.cc"],
hdrs = ["output_test.h"],
copts = TEST_COPTS,
deps = [
"//:benchmark",
"//:benchmark_internal_headers",
],
)
[
cc_test(
name = test_src[:-len(".cc")],
size = "small",
srcs = [test_src],
args = TEST_ARGS + PER_SRC_TEST_ARGS.get(test_src, []),
copts = TEST_COPTS + PER_SRC_COPTS.get(test_src, []),
deps = [
":output_test_helper",
"//:benchmark",
"//:benchmark_internal_headers",
"@com_google_googletest//:gtest",
] + (
["@com_google_googletest//:gtest_main"] if (test_src[-len("gtest.cc"):] == "gtest.cc") else []
),
# FIXME: Add support for assembly tests to bazel.
# See Issue #556
# https://github.com/google/benchmark/issues/556
)
for test_src in glob(
["*test.cc"],
exclude = [
"*_assembly_test.cc",
"link_main_test.cc",
],
)
]
cc_test(
name = "link_main_test",
size = "small",
srcs = ["link_main_test.cc"],
copts = TEST_COPTS,
deps = ["//:benchmark_main"],
)

third-party/benchmark/tools/BUILD.bazel

  • This file was deleted.
load("@py_deps//:requirements.bzl", "requirement")
py_library(
name = "gbench",
srcs = glob(["gbench/*.py"]),
deps = [
requirement("numpy"),
requirement("scipy"),
],
)
py_binary(
name = "compare",
srcs = ["compare.py"],
python_version = "PY2",
deps = [
":gbench",
],
)

third-party/update_benchmark.sh

#!/bin/bash #!/bin/bash
echo "This script deletes `benchmark`, clones it from github, together" echo "This script deletes `benchmark`, clones it from github, together"
echo "with its dependencies. It then removes .git* files and dirs." echo "with its dependencies. It then removes .git* files and dirs."
echo "NOTE!!!" echo "NOTE!!!"
echo "Please double-check the benchmark github wiki for any changes" echo "Please double-check the benchmark github wiki for any changes"
echo "to dependencies. Currently, these are limited to googletest." echo "to dependencies. Currently, these are limited to googletest."
echo echo
read -p "Press a key to continue, or Ctrl+C to cancel" read -p "Press a key to continue, or Ctrl+C to cancel"
rm -rf benchmark rm -rf benchmark
git clone https://github.com/google/benchmark.git git clone https://github.com/google/benchmark.git
rm -rf benchmark/.git* rm -rf benchmark/.git*
find benchmark/ -name BUILD -delete
find benchmark/ -name BUILD.bazel -delete
third-party/benchmark/bindings/python/google_benchmark/BUILD