This is an archive of the discontinued LLVM Phabricator instance.

Differential D115666

[mlir][ExecutionEngine] Fix native dependencies for AsmParser and Printer
ClosedPublic

Authored by nicolasvasilache on Dec 13 2021, 1:02 PM.

Details

Reviewers
mehdi_amini
hpmorgan
Commits
rG1c4d9ae83dbb: [mlir][ExecutionEngine] Fix native dependencies for AsmParser and Printer
Summary

This is a post-commit fix for https://reviews.llvm.org/D114338 which was landed as
https://reviews.llvm.org/rG050cc1cd6e6882eadba6e5ea7b588ca0b8aa1b12

Diff Detail

Event Timeline

nicolasvasilache created this revision.Dec 13 2021, 1:02 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptDec 13 2021, 1:02 PM
nicolasvasilache requested review of this revision.Dec 13 2021, 1:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2021, 1:02 PM
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
nicolasvasilache mentioned this in D114338: [mlir] Add InitializeNativeTargetAsmParser to ExecutionEngine..Dec 13 2021, 1:03 PM
nicolasvasilache added a reviewer: hpmorgan.
hpmorgan accepted this revision.Dec 13 2021, 1:11 PM

Much obliged!

This revision is now accepted and ready to land.Dec 13 2021, 1:11 PM
This revision was landed with ongoing or failed builds.Dec 13 2021, 1:14 PM
Closed by commit rG1c4d9ae83dbb: [mlir][ExecutionEngine] Fix native dependencies for AsmParser and Printer (authored by nicolasvasilache). · Explain Why
This revision was automatically updated to reflect the committed changes.
nicolasvasilache added a commit: rG1c4d9ae83dbb: [mlir][ExecutionEngine] Fix native dependencies for AsmParser and Printer.
Harbormaster completed remote builds in B139058: Diff 394019.Dec 13 2021, 1:26 PM

Revision Contents

PathSize
mlir/
lib/
CAPI/
ExecutionEngine/
5 lines
ExecutionEngine/
1 line

Diff 394025

mlir/lib/CAPI/ExecutionEngine/CMakeLists.txt

set(LLVM_LINK_COMPONENTS
nativecodegen
native
)
# Main API shared library. # Main API shared library.
add_mlir_upstream_c_api_library(MLIRCAPIExecutionEngine add_mlir_upstream_c_api_library(MLIRCAPIExecutionEngine
ExecutionEngine.cpp ExecutionEngine.cpp
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRExecutionEngine MLIRExecutionEngine
MLIRLLVMToLLVMIRTranslation MLIRLLVMToLLVMIRTranslation
) )

mlir/lib/ExecutionEngine/CMakeLists.txt

Show All 20 Linesadd_mlir_library(MLIRExecutionEngine
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/ExecutionEngine ${MLIR_MAIN_INCLUDE_DIR}/mlir/ExecutionEngine
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
LINK_COMPONENTS LINK_COMPONENTS
${LLVM_NATIVE_ARCH}AsmParser
Core Core
Coroutines Coroutines
ExecutionEngine ExecutionEngine
Object Object
OrcJIT OrcJIT
JITLink JITLink
Analysis Analysis
AggressiveInstCombine AggressiveInstCombine
▲ Show 20 Lines • Show All 176 Lines • Show Last 20 Lines