This is an archive of the discontinued LLVM Phabricator instance.

Differential D115644

[libc++] Remove C++ version guards in the dylib.
ClosedPublic

Authored by Mordante on Dec 13 2021, 9:32 AM.

Details

Reviewers
• Quuxplusone
ldionne
Group Reviewers
Restricted Project
Commits
rG0b9b1c8c49fd: [libc++] Remove C++ version guards in the dylib.
Summary

The library is always build using C++20 so these guards are not needed.

Diff Detail

Event Timeline

Mordante requested review of this revision.Dec 13 2021, 9:32 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2021, 9:32 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
• Quuxplusone accepted this revision as: • Quuxplusone.Dec 13 2021, 10:30 AM
• Quuxplusone added a subscriber: • Quuxplusone.

Seems reasonable to me!

Harbormaster completed remote builds in B138997: Diff 393931.Dec 13 2021, 10:50 AM
ldionne accepted this revision.Dec 13 2021, 11:28 AM
This revision is now accepted and ready to land.Dec 13 2021, 11:28 AM
Closed by commit rG0b9b1c8c49fd: [libc++] Remove C++ version guards in the dylib. (authored by Mordante). · Explain WhyDec 14 2021, 8:38 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG0b9b1c8c49fd: [libc++] Remove C++ version guards in the dylib..

Revision Contents

PathSize
libcxx/
src/
4 lines
4 lines

Diff 394273

libcxx/src/barrier.cpp

Show All 9 Lines
#ifndef _LIBCPP_HAS_NO_THREADS #ifndef _LIBCPP_HAS_NO_THREADS
#include <barrier> #include <barrier>
#include <thread> #include <thread>
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
#if !defined(_LIBCPP_HAS_NO_TREE_BARRIER) && (_LIBCPP_STD_VER > 11) #if !defined(_LIBCPP_HAS_NO_TREE_BARRIER)
class __barrier_algorithm_base { class __barrier_algorithm_base {
public: public:
struct alignas(64) /* naturally-align the heap state */ __state_t struct alignas(64) /* naturally-align the heap state */ __state_t
{ {
struct { struct {
__atomic_base<__barrier_phase_t> __phase = ATOMIC_VAR_INIT(0); __atomic_base<__barrier_phase_t> __phase = ATOMIC_VAR_INIT(0);
} __tickets[64]; } __tickets[64];
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Linesbool __arrive_barrier_algorithm_base(__barrier_algorithm_base* __barrier,
return __barrier->__arrive(__old_phase); return __barrier->__arrive(__old_phase);
} }
_LIBCPP_EXPORTED_FROM_ABI _LIBCPP_EXPORTED_FROM_ABI
void __destroy_barrier_algorithm_base(__barrier_algorithm_base* __barrier) void __destroy_barrier_algorithm_base(__barrier_algorithm_base* __barrier)
{ {
delete __barrier; delete __barrier;
} }
#endif //!defined(_LIBCPP_HAS_NO_TREE_BARRIER) && (_LIBCPP_STD_VER >= 11) #endif //!defined(_LIBCPP_HAS_NO_TREE_BARRIER)
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif //_LIBCPP_HAS_NO_THREADS #endif //_LIBCPP_HAS_NO_THREADS

libcxx/src/format.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "format" #include "format"
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
#if _LIBCPP_STD_VER > 17
format_error::~format_error() noexcept = default; format_error::~format_error() noexcept = default;
#endif //_LIBCPP_STD_VER > 17
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD