This is an archive of the discontinued LLVM Phabricator instance.

tsan: deflake flush_memory.cpp
ClosedPublic

Authored by dvyukov on Dec 13 2021, 12:33 AM.

Details

Summary

The test contains a race and checks that it's detected.
But the race may not be detected since we are doing aggressive flushes
and if the state flush happens between racing accesses, tsan won't
detect the race). So return 1 to make the test deterministic
regardless of the race.

Diff Detail

Unit TestsFailed

Event Timeline

dvyukov requested review of this revision.Dec 13 2021, 12:33 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2021, 12:33 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Dec 13 2021, 2:59 AM
This revision is now accepted and ready to land.Dec 13 2021, 2:59 AM
This revision was landed with ongoing or failed builds.Dec 13 2021, 3:01 AM
This revision was automatically updated to reflect the committed changes.