This is an archive of the discontinued LLVM Phabricator instance.

Differential D115589

[adt] Fix compiler warning in test
ClosedPublic

Authored by springerm on Dec 11 2021, 5:09 PM.

Details

Reviewers
None
Commits
rG7029a688c904: [adt] Fix compiler warning in test

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

springerm requested review of this revision.Dec 11 2021, 5:09 PM
springerm created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2021, 5:09 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
springerm added a subscriber: lbenes.Dec 11 2021, 5:11 PM
Harbormaster completed remote builds in B138831: Diff 393712.Dec 11 2021, 5:57 PM
lbenes added a comment.Dec 11 2021, 6:49 PM

See commit d79bb30dbb08910816859ccaae1ca5d04fbd9501

This avoids a -pedantic warning:
warning: ISO C++11 requires at least one argument for the "..." in a variadic macro

See also https://github.com/google/googletest/issues/2271

This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2021, 11:18 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG7029a688c904: [adt] Fix compiler warning in test (authored by springerm). · Explain Why
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rG7029a688c904: [adt] Fix compiler warning in test.

Revision Contents

PathSize
llvm/
unittests/
ADT/
2 lines

Diff 393712

llvm/unittests/ADT/EquivalenceClassesTest.cpp

Show First 20 Lines • Show All 105 Lines • ▼ Show 20 Lines
}; };
} // namespace } // namespace
REGISTER_TYPED_TEST_SUITE_P(ParameterizedTest, MultipleSets); REGISTER_TYPED_TEST_SUITE_P(ParameterizedTest, MultipleSets);
using ParamTypes = using ParamTypes =
testing::Types<EquivalenceClasses<int>, testing::Types<EquivalenceClasses<int>,
EquivalenceClasses<TestStruct, TestStructComparator>>; EquivalenceClasses<TestStruct, TestStructComparator>>;
INSTANTIATE_TYPED_TEST_SUITE_P(EquivalenceClassesTest, ParameterizedTest, INSTANTIATE_TYPED_TEST_SUITE_P(EquivalenceClassesTest, ParameterizedTest,
ParamTypes); ParamTypes, );
} // llvm } // llvm