This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers] Fix decorator test to ignore the executable attribute as this was causing flakiness.
AbandonedPublic

Authored by kstoimenov on Dec 10 2021, 11:23 AM.

Details

Diff Detail

Event Timeline

kstoimenov requested review of this revision.Dec 10 2021, 11:23 AM
kstoimenov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2021, 11:23 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Is this after callback patch? I don't remember I've seen this before

I just wrote the same patch, plus this comment:

In the regex below, the x permission is matched with a '.'.
We would like '-', but sometimes 'x' is set, causing buildbot flakiness.
This might be due to READ_IMPLIES_EXEC being set (when it occurs all regions with r also have x).
TODO: investigate further and change 'rw{{[-x]}}p' back to 'rw-p'

browneee accepted this revision.Dec 10 2021, 12:37 PM

Suggest adding a comment and submitting to make that buildbot green.

Can revert later when we figure out why.

This revision is now accepted and ready to land.Dec 10 2021, 12:37 PM

Added a commented recommended by browneee@.

Why do you think it's flakiness, it's consistently red on two different host

Updated the comment.

And it's consistently red after D114558.

kstoimenov abandoned this revision.Dec 10 2021, 1:56 PM

Thanks, Andrew. I will submit my patch. I've added your comments.