This is an archive of the discontinued LLVM Phabricator instance.

Differential D115468

CMake: Suppress warnings from llvm-libtool
AcceptedPublic

Authored by dexonsmith on Dec 9 2021, 1:56 PM.

Details

Reviewers
alexander-shaposhnikov
keith
Summary

cdcb60a820571f7384920fb534ce23e7568bfc03 added warnings for objects with
no symbols and the -no_warning_for_no_symbols flag. That commit landed
in LLVM 13.0.0. Update CMake configuration to use the flag.

Diff Detail

Event Timeline

dexonsmith created this revision.Dec 9 2021, 1:56 PM
Herald added a subscriber: mgorny. · View Herald TranscriptDec 9 2021, 1:56 PM
dexonsmith requested review of this revision.Dec 9 2021, 1:56 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 9 2021, 1:56 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
keith accepted this revision.Dec 9 2021, 2:03 PM
This revision is now accepted and ready to land.Dec 9 2021, 2:03 PM
Harbormaster completed remote builds in B138524: Diff 393280.Dec 9 2021, 2:50 PM

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
6 lines
llvm/
cmake/
modules/
6 lines

Diff 393280

compiler-rt/cmake/Modules/UseLibtool.cmake

Show All 22 Lines execute_process(COMMAND ${CMAKE_LIBTOOL} -V
OUTPUT_VARIABLE LIBTOOL_V_OUTPUT OUTPUT_VARIABLE LIBTOOL_V_OUTPUT
OUTPUT_STRIP_TRAILING_WHITESPACE) OUTPUT_STRIP_TRAILING_WHITESPACE)
if("${LIBTOOL_V_OUTPUT}" MATCHES ".*cctools-([0-9.]+).*") if("${LIBTOOL_V_OUTPUT}" MATCHES ".*cctools-([0-9.]+).*")
string(REGEX REPLACE ".*cctools-([0-9.]+).*" "\\1" LIBTOOL_VERSION string(REGEX REPLACE ".*cctools-([0-9.]+).*" "\\1" LIBTOOL_VERSION
${LIBTOOL_V_OUTPUT}) ${LIBTOOL_V_OUTPUT})
if(NOT LIBTOOL_VERSION VERSION_LESS "862") if(NOT LIBTOOL_VERSION VERSION_LESS "862")
set(LIBTOOL_NO_WARNING_FLAG "-no_warning_for_no_symbols") set(LIBTOOL_NO_WARNING_FLAG "-no_warning_for_no_symbols")
endif() endif()
elseif("${LIBTOOL_V_OUTPUT}" MATCHES "LLVM version ([0-9.]+).*")
string(REGEX REPLACE ".*LLVM version ([0-9.]+).*" "\\1" LIBTOOL_VERSION
${LIBTOOL_V_OUTPUT})
if(NOT LIBTOOL_VERSION VERSION_LESS "13")
set(LIBTOOL_NO_WARNING_FLAG "-no_warning_for_no_symbols")
endif()
endif() endif()
foreach(lang ${languages}) foreach(lang ${languages})
set(CMAKE_${lang}_CREATE_STATIC_LIBRARY set(CMAKE_${lang}_CREATE_STATIC_LIBRARY
"\"${CMAKE_LIBTOOL}\" -static ${LIBTOOL_NO_WARNING_FLAG} -o <TARGET> <LINK_FLAGS> <OBJECTS>") "\"${CMAKE_LIBTOOL}\" -static ${LIBTOOL_NO_WARNING_FLAG} -o <TARGET> <LINK_FLAGS> <OBJECTS>")
endforeach() endforeach()
# By default, CMake invokes ranlib on a static library after installing it. # By default, CMake invokes ranlib on a static library after installing it.
Show All 20 Lines

llvm/cmake/modules/UseLibtool.cmake

Show All 22 Lines execute_process(COMMAND ${CMAKE_LIBTOOL} -V
OUTPUT_VARIABLE LIBTOOL_V_OUTPUT OUTPUT_VARIABLE LIBTOOL_V_OUTPUT
OUTPUT_STRIP_TRAILING_WHITESPACE) OUTPUT_STRIP_TRAILING_WHITESPACE)
if("${LIBTOOL_V_OUTPUT}" MATCHES ".*cctools-([0-9.]+).*") if("${LIBTOOL_V_OUTPUT}" MATCHES ".*cctools-([0-9.]+).*")
string(REGEX REPLACE ".*cctools-([0-9.]+).*" "\\1" LIBTOOL_VERSION string(REGEX REPLACE ".*cctools-([0-9.]+).*" "\\1" LIBTOOL_VERSION
${LIBTOOL_V_OUTPUT}) ${LIBTOOL_V_OUTPUT})
if(NOT LIBTOOL_VERSION VERSION_LESS "862") if(NOT LIBTOOL_VERSION VERSION_LESS "862")
set(LIBTOOL_NO_WARNING_FLAG "-no_warning_for_no_symbols") set(LIBTOOL_NO_WARNING_FLAG "-no_warning_for_no_symbols")
endif() endif()
elseif("${LIBTOOL_V_OUTPUT}" MATCHES "LLVM version ([0-9.]+).*")
string(REGEX REPLACE ".*LLVM version ([0-9.]+).*" "\\1" LIBTOOL_VERSION
${LIBTOOL_V_OUTPUT})
if(NOT LIBTOOL_VERSION VERSION_LESS "13")
set(LIBTOOL_NO_WARNING_FLAG "-no_warning_for_no_symbols")
endif()
endif() endif()
foreach(lang ${languages}) foreach(lang ${languages})
set(CMAKE_${lang}_CREATE_STATIC_LIBRARY set(CMAKE_${lang}_CREATE_STATIC_LIBRARY
"\"${CMAKE_LIBTOOL}\" -static ${LIBTOOL_NO_WARNING_FLAG} -o <TARGET> <LINK_FLAGS> <OBJECTS>") "\"${CMAKE_LIBTOOL}\" -static ${LIBTOOL_NO_WARNING_FLAG} -o <TARGET> <LINK_FLAGS> <OBJECTS>")
endforeach() endforeach()
endif() endif()
Show All 12 Lines