This is an archive of the discontinued LLVM Phabricator instance.

[NFC][CodeView] Use one unified access to the module in beginModule.
ClosedPublic

Authored by cchen15 on Dec 7 2021, 8:36 AM.

Details

Summary

Use the argument M throughout the function.

The current code can trigger warnings from a static checker as the checker may not be able to deduce that M is the same as MMI->getModule().

Diff Detail

Event Timeline

cchen15 created this revision.Dec 7 2021, 8:36 AM
cchen15 requested review of this revision.Dec 7 2021, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2021, 8:36 AM
rnk accepted this revision.Dec 7 2021, 10:42 AM

lgtm

This revision is now accepted and ready to land.Dec 7 2021, 10:42 AM

Thanks for the review, Reid.