This is an archive of the discontinued LLVM Phabricator instance.

Differential D115209

Add baseline tests for icmp bool with not on LHS
ClosedPublic

Authored by hasyimibhar on Dec 6 2021, 5:48 PM.

Details

Reviewers
spatel
Commits
rG64d4bd02dc3f: [InstCombine][InstSimplify] Add baseline tests for icmp bool with not on LHS…
Summary

Adds tests for both -instsimplify and -instcombine. The difference between the CHECK result of these 2 tests
highlights missed folds in instsimplify (e.g. (icmp eq (xor X, true), false) -> X) that are already being handled by instcombine.

The tests are based on llvm/test/Transforms/InstSimplify/icmp-bool-constant.ll

Diff Detail

Event Timeline

hasyimibhar requested review of this revision.Dec 6 2021, 5:48 PM
hasyimibhar created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2021, 5:48 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
hasyimibhar added a reviewer: spatel.Dec 6 2021, 5:49 PM
hasyimibhar mentioned this in D114666: [InstSimplify] Simplify bool icmp with not in LHS.
hasyimibhar edited the summary of this revision. (Show Details)Dec 6 2021, 5:54 PM
hasyimibhar edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B137794: Diff 392246.Dec 6 2021, 6:23 PM
spatel accepted this revision.Dec 7 2021, 6:02 AM

LGTM - if I should commit on your behalf, please let me know how to specify your author credentials:
https://llvm.org/docs/DeveloperPolicy.html#commit-messages

This revision is now accepted and ready to land.Dec 7 2021, 6:02 AM
hasyimibhar added a comment.Dec 7 2021, 2:11 PM
In D115209#3176280, @spatel wrote:

LGTM - if I should commit on your behalf, please let me know how to specify your author credentials:
https://llvm.org/docs/DeveloperPolicy.html#commit-messages

It should be Hasyimi Bahrudin <hasyimi@gatech.edu>.

Closed by commit rG64d4bd02dc3f: [InstCombine][InstSimplify] Add baseline tests for icmp bool with not on LHS… (authored by hasyimibhar, committed by spatel). · Explain WhyDec 8 2021, 5:48 AM
This revision was automatically updated to reflect the committed changes.
spatel added a commit: rG64d4bd02dc3f: [InstCombine][InstSimplify] Add baseline tests for icmp bool with not on LHS….

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
192 lines
InstSimplify/
204 lines

Diff 392729

llvm/test/Transforms/InstCombine/icmp-not-bool-constant.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instcombine -S | FileCheck %s
; Test all integer predicates with bool types and true/false constants,
; with not on LHS (icmp pred (xor X, true), true|false).
; Use vectors to provide test coverage that is not duplicated in other folds.
define <2 x i1> @eq_t_not(<2 x i1> %a) {
; CHECK-LABEL: @eq_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp eq <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @eq_f_not(<2 x i1> %a) {
; CHECK-LABEL: @eq_f_not(
; CHECK-NEXT: ret <2 x i1> [[A:%.*]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp eq <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ne_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ne_t_not(
; CHECK-NEXT: ret <2 x i1> [[A:%.*]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ne <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ne_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ne_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ne <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ugt_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ugt_t_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ugt <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ugt_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ugt_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ugt <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ult_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ult_t_not(
; CHECK-NEXT: ret <2 x i1> [[A:%.*]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ult <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ult_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ult_f_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ult <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @sgt_t_not(<2 x i1> %a) {
; CHECK-LABEL: @sgt_t_not(
; CHECK-NEXT: ret <2 x i1> [[A:%.*]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sgt <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @sgt_f_not(<2 x i1> %a) {
; CHECK-LABEL: @sgt_f_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sgt <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @slt_t_not(<2 x i1> %a) {
; CHECK-LABEL: @slt_t_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp slt <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @slt_f_not(<2 x i1> %a) {
; CHECK-LABEL: @slt_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp slt <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @uge_t_not(<2 x i1> %a) {
; CHECK-LABEL: @uge_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp uge <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @uge_f_not(<2 x i1> %a) {
; CHECK-LABEL: @uge_f_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp uge <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ule_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ule_t_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ule <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ule_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ule_f_not(
; CHECK-NEXT: ret <2 x i1> [[A:%.*]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ule <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @sge_t_not(<2 x i1> %a) {
; CHECK-LABEL: @sge_t_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sge <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @sge_f_not(<2 x i1> %a) {
; CHECK-LABEL: @sge_f_not(
; CHECK-NEXT: ret <2 x i1> [[A:%.*]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sge <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @sle_t_not(<2 x i1> %a) {
; CHECK-LABEL: @sle_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sle <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @sle_f_not(<2 x i1> %a) {
; CHECK-LABEL: @sle_f_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sle <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}

llvm/test/Transforms/InstSimplify/icmp-not-bool-constant.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instsimplify -S | FileCheck %s
; Test all integer predicates with bool types and true/false constants,
; with not on LHS (icmp pred (xor X, true), true|false).
; Use vectors to provide test coverage that is not duplicated in other folds.
define <2 x i1> @eq_t_not(<2 x i1> %a) {
; CHECK-LABEL: @eq_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp eq <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @eq_f_not(<2 x i1> %a) {
; CHECK-LABEL: @eq_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: [[R:%.*]] = icmp eq <2 x i1> [[NOT]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp eq <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ne_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ne_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: [[R:%.*]] = icmp ne <2 x i1> [[NOT]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ne <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ne_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ne_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ne <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ugt_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ugt_t_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ugt <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ugt_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ugt_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ugt <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ult_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ult_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: [[R:%.*]] = icmp ult <2 x i1> [[NOT]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ult <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ult_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ult_f_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ult <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @sgt_t_not(<2 x i1> %a) {
; CHECK-LABEL: @sgt_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: [[R:%.*]] = icmp sgt <2 x i1> [[NOT]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sgt <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @sgt_f_not(<2 x i1> %a) {
; CHECK-LABEL: @sgt_f_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sgt <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @slt_t_not(<2 x i1> %a) {
; CHECK-LABEL: @slt_t_not(
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp slt <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @slt_f_not(<2 x i1> %a) {
; CHECK-LABEL: @slt_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp slt <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @uge_t_not(<2 x i1> %a) {
; CHECK-LABEL: @uge_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp uge <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @uge_f_not(<2 x i1> %a) {
; CHECK-LABEL: @uge_f_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp uge <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @ule_t_not(<2 x i1> %a) {
; CHECK-LABEL: @ule_t_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ule <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @ule_f_not(<2 x i1> %a) {
; CHECK-LABEL: @ule_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: [[R:%.*]] = icmp ule <2 x i1> [[NOT]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp ule <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @sge_t_not(<2 x i1> %a) {
; CHECK-LABEL: @sge_t_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sge <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @sge_f_not(<2 x i1> %a) {
; CHECK-LABEL: @sge_f_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: [[R:%.*]] = icmp sge <2 x i1> [[NOT]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sge <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}
define <2 x i1> @sle_t_not(<2 x i1> %a) {
; CHECK-LABEL: @sle_t_not(
; CHECK-NEXT: [[NOT:%.*]] = xor <2 x i1> [[A:%.*]], <i1 true, i1 true>
; CHECK-NEXT: ret <2 x i1> [[NOT]]
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sle <2 x i1> %not, <i1 true, i1 true>
ret <2 x i1> %r
}
define <2 x i1> @sle_f_not(<2 x i1> %a) {
; CHECK-LABEL: @sle_f_not(
; CHECK-NEXT: ret <2 x i1> <i1 true, i1 true>
;
%not = xor <2 x i1> %a, <i1 true, i1 true>
%r = icmp sle <2 x i1> %not, <i1 false, i1 false>
ret <2 x i1> %r
}