Page MenuHomePhabricator

hasyimibhar (Hasyimi Bahrudin)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2021, 8:34 AM (36 w, 2 d)

Recent Activity

Dec 12 2021

hasyimibhar updated the summary of D102591: Fix DIObjCProperty getter and setter swapped during parsing.
Dec 12 2021, 4:18 AM · Restricted Project
hasyimibhar added a comment to D102591: Fix DIObjCProperty getter and setter swapped during parsing.

The bug is still there: https://alive2.llvm.org/ce/z/Du9B7W

Dec 12 2021, 4:17 AM · Restricted Project
hasyimibhar updated the diff for D102591: Fix DIObjCProperty getter and setter swapped during parsing.

Rebase to main

Dec 12 2021, 4:13 AM · Restricted Project

Dec 9 2021

hasyimibhar updated the diff for D115480: [InstCombine] Fold icmp of truncated left shift.

Run git-clang-format

Dec 9 2021, 4:33 PM · Restricted Project
hasyimibhar added inline comments to D115480: [InstCombine] Fold icmp of truncated left shift.
Dec 9 2021, 4:32 PM · Restricted Project
hasyimibhar updated the summary of D115480: [InstCombine] Fold icmp of truncated left shift.
Dec 9 2021, 4:18 PM · Restricted Project
hasyimibhar added a reviewer for D115480: [InstCombine] Fold icmp of truncated left shift: spatel.
Dec 9 2021, 4:16 PM · Restricted Project
hasyimibhar requested review of D115480: [InstCombine] Fold icmp of truncated left shift.
Dec 9 2021, 4:16 PM · Restricted Project
hasyimibhar updated the diff for D115459: [InstSimplify] Fold compare of no-wrap subtract.

Add missing CHECK

Dec 9 2021, 11:49 AM · Restricted Project
hasyimibhar added a reviewer for D115459: [InstSimplify] Fold compare of no-wrap subtract: spatel.
Dec 9 2021, 11:45 AM · Restricted Project
hasyimibhar requested review of D115459: [InstSimplify] Fold compare of no-wrap subtract.
Dec 9 2021, 11:45 AM · Restricted Project
hasyimibhar added inline comments to D114666: [InstSimplify] Simplify bool icmp with not in LHS.
Dec 9 2021, 8:07 AM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Revert test rename

Dec 9 2021, 7:10 AM · Restricted Project
hasyimibhar added a comment to D114666: [InstSimplify] Simplify bool icmp with not in LHS.

I added 2 extra test cases for each of the 6 cases:

Dec 9 2021, 7:05 AM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.
  • Fix missing break
  • Use m_Not instead of m_Xor
  • Add more test cases
Dec 9 2021, 7:02 AM · Restricted Project
hasyimibhar added inline comments to D114666: [InstSimplify] Simplify bool icmp with not in LHS.
Dec 9 2021, 6:35 AM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Run git-clang-format

Dec 9 2021, 5:27 AM · Restricted Project
hasyimibhar updated the summary of D114666: [InstSimplify] Simplify bool icmp with not in LHS.
Dec 9 2021, 5:02 AM · Restricted Project
hasyimibhar added a comment to D114666: [InstSimplify] Simplify bool icmp with not in LHS.

I fixed the logic so that only 6 cases should be affected. I double checked with this: https://alive2.llvm.org/ce/z/uZiDpt

Dec 9 2021, 5:00 AM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Fix simplification logic

Dec 9 2021, 4:55 AM · Restricted Project

Dec 7 2021

hasyimibhar added a comment to D115209: Add baseline tests for icmp bool with not on LHS.

LGTM - if I should commit on your behalf, please let me know how to specify your author credentials:
https://llvm.org/docs/DeveloperPolicy.html#commit-messages

Dec 7 2021, 2:11 PM · Restricted Project

Dec 6 2021

hasyimibhar updated the summary of D115209: Add baseline tests for icmp bool with not on LHS.
Dec 6 2021, 5:55 PM · Restricted Project
hasyimibhar updated the summary of D115209: Add baseline tests for icmp bool with not on LHS.
Dec 6 2021, 5:54 PM · Restricted Project
hasyimibhar added a comment to D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Baseline tests added here: https://reviews.llvm.org/D115209

Dec 6 2021, 5:50 PM · Restricted Project
hasyimibhar added a reviewer for D115209: Add baseline tests for icmp bool with not on LHS: spatel.
Dec 6 2021, 5:49 PM · Restricted Project
hasyimibhar requested review of D115209: Add baseline tests for icmp bool with not on LHS.
Dec 6 2021, 5:48 PM · Restricted Project

Dec 5 2021

hasyimibhar added a comment to D114666: [InstSimplify] Simplify bool icmp with not in LHS.

I don't think the logic is correct. You should start by creating a complete set of baseline tests based on the existing tests in:
https://github.com/llvm/llvm-project/blob/main/llvm/test/Transforms/InstSimplify/icmp-bool-constant.ll

We can then pre-commit those tests ahead of this patch to make sure we get correct results in all cases with this patch.

You may also want to check how these patterns are handled by "opt -instcombine" (assuming they are handled correctly there).

Dec 5 2021, 9:18 AM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Don't change LHS and Pred

Dec 5 2021, 9:13 AM · Restricted Project

Dec 4 2021

hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Fix author email

Dec 4 2021, 11:46 PM · Restricted Project
hasyimibhar retitled D114666: [InstSimplify] Simplify bool icmp with not in LHS from [InstSimplify] Fold bool(X) ^ 1 == 0 to X to [InstSimplify] Simplify bool icmp with not in LHS.
Dec 4 2021, 11:37 PM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Fix commit

Dec 4 2021, 11:36 PM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Rebase

Dec 4 2021, 11:31 PM · Restricted Project
hasyimibhar added a comment to D114666: [InstSimplify] Simplify bool icmp with not in LHS.

@spatel Updated to handle general pattern. Let me know if this is what you mean, as I'm pretty new to LLVM.

Dec 4 2021, 11:28 PM · Restricted Project
hasyimibhar updated the diff for D114666: [InstSimplify] Simplify bool icmp with not in LHS.

Handle general case with not in LHS

Dec 4 2021, 11:27 PM · Restricted Project

Nov 27 2021

hasyimibhar retitled D114666: [InstSimplify] Simplify bool icmp with not in LHS from Simplify icmp for bool value to [InstSimplify] Fold bool(X) ^ 1 == 0 to X.
Nov 27 2021, 8:51 AM · Restricted Project
hasyimibhar added a reviewer for D114666: [InstSimplify] Simplify bool icmp with not in LHS: spatel.
Nov 27 2021, 8:26 AM · Restricted Project
hasyimibhar requested review of D114666: [InstSimplify] Simplify bool icmp with not in LHS.
Nov 27 2021, 8:25 AM · Restricted Project

May 26 2021

hasyimibhar added a reviewer for D102591: Fix DIObjCProperty getter and setter swapped during parsing: mehdi_amini.
May 26 2021, 10:05 PM · Restricted Project
hasyimibhar added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

Thanks! This is basically my first patch. Now do I just wait for someone to commit on my behalf? Or does it still need more acceptance?

May 26 2021, 7:14 PM · Restricted Project

May 23 2021

hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Fix clang-tidy error

May 23 2021, 5:05 PM · Restricted Project
hasyimibhar added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 23 2021, 3:01 PM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Use int for maxNameSize

May 23 2021, 3:00 PM · Restricted Project
hasyimibhar added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 23 2021, 2:59 PM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Use maxNameSize argument in constructor

May 23 2021, 7:42 AM · Restricted Project
hasyimibhar added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 23 2021, 7:26 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Add isLocal to ValueSymbolTable to differentiate usage

May 23 2021, 7:13 AM · Restricted Project

May 22 2021

hasyimibhar added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

Does anyone know why the test omp_init_lock.c is failing? I have no idea how it's related to the change.

May 22 2021, 5:24 AM · Restricted Project

May 21 2021

hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Run clang-format

May 21 2021, 5:32 PM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Add LocalValueSymbolTable

May 21 2021, 3:08 PM · Restricted Project
hasyimibhar added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 21 2021, 1:37 PM · Restricted Project

May 20 2021

hasyimibhar updated the summary of D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 20 2021, 4:15 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Fix clang-tidy error

May 20 2021, 2:26 AM · Restricted Project
hasyimibhar added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 20 2021, 1:27 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Move capping to ValueSymbolTable

May 20 2021, 1:22 AM · Restricted Project

May 19 2021

hasyimibhar added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 19 2021, 10:15 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Move call of capLocalValueName into ValueSymbolTable

May 19 2021, 10:13 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Fix clang-tidy error

May 19 2021, 3:20 AM · Restricted Project
hasyimibhar added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 19 2021, 3:15 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Remove duplicate code

May 19 2021, 12:20 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Use StringRef and simplify test. I also removed inline in the function definition because it's actually causing a linker error (my C++ is a bit rusty).

May 19 2021, 12:15 AM · Restricted Project

May 18 2021

hasyimibhar added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

This is pretty much my first patch for LLVM, so let me know if I'm doing something wrong. The function capLocalValueName is added because I'm not sure how NonGlobalValueMaxNameSize can be exposed outside of Value.cpp.

May 18 2021, 11:42 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Add description to test

May 18 2021, 11:39 AM · Restricted Project
hasyimibhar updated the summary of D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 18 2021, 11:36 AM · Restricted Project
hasyimibhar added reviewers for D102707: Fix non-global-value-max-name-size not considered by LLParser: serge-sans-paille, uabelho.
May 18 2021, 11:35 AM · Restricted Project
hasyimibhar updated the diff for D102707: Fix non-global-value-max-name-size not considered by LLParser.

Remove whitespace

May 18 2021, 11:32 AM · Restricted Project
hasyimibhar requested review of D102707: Fix non-global-value-max-name-size not considered by LLParser.
May 18 2021, 11:30 AM · Restricted Project

May 16 2021

hasyimibhar updated the summary of D102591: Fix DIObjCProperty getter and setter swapped during parsing.
May 16 2021, 8:26 PM · Restricted Project
hasyimibhar updated the summary of D102591: Fix DIObjCProperty getter and setter swapped during parsing.
May 16 2021, 8:25 PM · Restricted Project
hasyimibhar added a reviewer for D102591: Fix DIObjCProperty getter and setter swapped during parsing: dexonsmith.
May 16 2021, 8:22 PM · Restricted Project
hasyimibhar requested review of D102591: Fix DIObjCProperty getter and setter swapped during parsing.
May 16 2021, 8:18 PM · Restricted Project