[test-release.sh] Add an option to build lib projects as a part of default runtimes.

[ldionne]

Summary

This patch adds an option to the test-release.sh script to build some of the LLVM projects
(particularly compiler-rt/libcxx/libcxxabi/libunwind) as the default runtimes (with the -LLVM_ENABLE_RUNTIMES)
CMake invocation.

The intention behind this patch is not only that we plan to build some of these projects in this way
on AIX, but also is in correspondence to the thread that @ldionne previously posted regarding the changes
in how we build these projects at https://lists.llvm.org/pipermail/llvm-dev/2021-October/153238.html.

[amyk]

My initial thought with this patch was to add the ability to supply the list of projects by a semicolon delimited
list with the --runtimes option, but of course, feedback is welcome with how exactly we want to achieve this
with test-release.sh and this method may not be the best way.

I primarily wanted to post this Phabricator review to start the discussion on building with
-DLLVM_ENABLE_PROJECTS within the release testing script.

[ldionne]

Nitpick: In your commit message, I think you mean LLVM_ENABLE_RUNTIMES, not LLVM_ENABLE_PROJECTS.

I'm fine-ish with this change. Another approach would be D112748, where we automatically route various runtimes to LLVM_ENABLE_RUNTIMES without having to change how test-release.sh is invoked. I'm fine with either, I don't really have a preference.

[amyk]

In D115105#3174149, @ldionne wrote:

Nitpick: In your commit message, I think you mean LLVM_ENABLE_RUNTIMES, not LLVM_ENABLE_PROJECTS.

I'm fine-ish with this change. Another approach would be D112748, where we automatically route various runtimes to LLVM_ENABLE_RUNTIMES without having to change how test-release.sh is invoked. I'm fine with either, I don't really have a preference.

Oops - yes, that is right. Thanks for letting me know @ldionne! And sorry for missing the initial Phabricator revision that was put up. I've actually added a few comments to your revision to keep the conversation more contained.

[ldionne]

[Github PR transition cleanup]

Commandeering to close since we did D112748 instead.

llvm/utils/release/test-release.sh

 else
     MAKE=make
 fi
 generator="Unix Makefiles"
 
 Release=""
 Release_no_dot=""
 RC=""
+Runtimes=""
 Triple=""
 use_gzip="no"
 do_checkout="yes"
 do_debug="no"
 do_asserts="no"
 do_compare="yes"
 do_rt="yes"
 do_libs="yes"

 ExportBranch=""
 git_ref=""
 
 function usage() {
     echo "usage: `basename $0` -release X.Y.Z -rc NUM [OPTIONS]"
     echo ""
     echo " -release X.Y.Z       The release version to test."
     echo " -rc NUM              The pre-release candidate number."
+    echo " -runtimes PROJECTS   Projects to be built as apart of runtimes (semicolon separated list)."
     echo " -final               The final release candidate."
     echo " -triple TRIPLE       The target triple for this machine."
     echo " -j NUM               Number of compile jobs to run. [default: 3]"
     echo " -build-dir DIR       Directory to perform testing in. [default: pwd]"
     echo " -no-checkout         Don't checkout the sources from SVN."
     echo " -test-debug          Test the debug build. [default: no]"
     echo " -test-asserts        Test with asserts on. [default: no]"
     echo " -no-compare-files    Don't test that phase 2 and 3 files are identical."
case $1 in
             shift
             Release="$1"
             Release_no_dot="`echo $1 | sed -e 's,\.,,g'`"
             ;;
         -rc | --rc | -RC | --RC )
             shift
             RC="rc$1"
             ;;
+        -runtimes | --runtimes )
+            shift
+            Runtimes="$1"
+            ;;
         -final | --final )
             RC=final
             ;;
         -git-ref | --git-ref )
             shift
             Release="test"
             Release_no_dot="test"
             ExportBranch="$1"
if [ -z "$NumJobs" ]; then
     NumJobs=`grep -c processor /proc/cpuinfo 2> /dev/null || true`
 fi
 if [ -z "$NumJobs" ]; then
     NumJobs=3
 fi
 
 # Projects list
 projects="llvm clang clang-tools-extra"
-if [ $do_rt = "yes" ]; then
+if [ $do_rt = "yes" ] && [[ $Runtimes != *"compiler-rt"* ]]; then
   projects="$projects compiler-rt"
 fi
-if [ $do_libs = "yes" ]; then
+if [ $do_libs = "yes" ] && [[ $Runtimes != *"libcxx"* ]]; then
   projects="$projects libcxx"
-  if [ $do_libcxxabi = "yes" ]; then
+  if [ $do_libcxxabi = "yes" ] && [[ $Runtimes != *"libcxxabi"* ]]; then
     projects="$projects libcxxabi"
   fi
-  if [ $do_libunwind = "yes" ]; then
+  if [ $do_libunwind = "yes" ] && [[ $Runtimes != *"libunwind"* ]]; then
     projects="$projects libunwind"
   fi
 fi
 case $do_test_suite in
   yes|export-only)
     projects="$projects test-suite"
     ;;
 esac
function configure_llvmCore() {
 
     cd $ObjDir
     echo "# Configuring llvm $Release-$RC $Flavor"
 
     echo "#" env CC="$c_compiler" CXX="$cxx_compiler" \
         cmake -G "$generator" \
         -DCMAKE_BUILD_TYPE=$BuildType -DLLVM_ENABLE_ASSERTIONS=$Assertions \
         -DLLVM_ENABLE_PROJECTS="$project_list" \
+        -DLLVM_ENABLE_RUNTIMES="$Runtimes" \
         $ExtraConfigureFlags $BuildDir/llvm-project/llvm \
         2>&1 | tee $LogDir/llvm.configure-Phase$Phase-$Flavor.log
     env CC="$c_compiler" CXX="$cxx_compiler" \
         cmake -G "$generator" \
         -DCMAKE_BUILD_TYPE=$BuildType -DLLVM_ENABLE_ASSERTIONS=$Assertions \
         -DLLVM_ENABLE_PROJECTS="$project_list" \
+        -DLLVM_ENABLE_RUNTIMES="$Runtimes" \
         $ExtraConfigureFlags $BuildDir/llvm-project/llvm \
         2>&1 | tee $LogDir/llvm.configure-Phase$Phase-$Flavor.log
 
     cd $BuildDir
 }
 
 function build_llvmCore() {
     Phase="$1"