This is an archive of the discontinued LLVM Phabricator instance.

Differential D114970

[bazel][mlgo] Remove the mlgo-related build excludes
ClosedPublic

Authored by mtrofin on Dec 2 2021, 9:41 AM.

Details

Reviewers
GMNGeoffrey
Commits
rGced5fd8dbf90: [bazel][mlgo] Remove the mlgo-related build excludes
Summary

They aren't needed anymore, we handle conditional compilation in those
files.

Diff Detail

Event Timeline

mtrofin requested review of this revision.Dec 2 2021, 9:41 AM
mtrofin created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2021, 9:41 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
GMNGeoffrey accepted this revision.Dec 2 2021, 9:41 AM
This revision is now accepted and ready to land.Dec 2 2021, 9:41 AM
GMNGeoffrey added a comment.Dec 2 2021, 9:42 AM

LGTM. Please wait for the Bazel pre-merge check to pass before landing

Harbormaster completed remote builds in B137164: Diff 391364.Dec 2 2021, 9:48 AM
Closed by commit rGced5fd8dbf90: [bazel][mlgo] Remove the mlgo-related build excludes (authored by mtrofin). · Explain WhyDec 2 2021, 9:51 AM
This revision was automatically updated to reflect the committed changes.
mtrofin added a commit: rGced5fd8dbf90: [bazel][mlgo] Remove the mlgo-related build excludes.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
llvm/
11 lines

Diff 391364

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

Show First 20 Lines • Show All 843 Lines • ▼ Show 20 Lines
cc_library( cc_library(
name = "Analysis", name = "Analysis",
srcs = glob( srcs = glob(
[ [
"lib/Analysis/*.cpp", "lib/Analysis/*.cpp",
"lib/Analysis/*.h", "lib/Analysis/*.h",
"lib/Analysis/*.def", "lib/Analysis/*.def",
], ],
exclude = [
# TODO(mtrofin): Add these files to the build.
"lib/Analysis/MLInlineAdvisor.cpp",
"lib/Analysis/DevelopmentModeInlineAdvisor.cpp",
"lib/Analysis/ReleaseModeModelRunner.cpp",
"lib/Analysis/TFUtils.cpp",
],
), ),
hdrs = glob( hdrs = glob(
[ [
"include/llvm/Analysis/*.h", "include/llvm/Analysis/*.h",
"include/llvm/Analysis/Utils/*.h", "include/llvm/Analysis/Utils/*.h",
], ],
exclude = [
# TODO(mtrofin): Add this file to the build.
"include/llvm/Analysis/Utils/TFUtils.h",
],
) + [ ) + [
"include/llvm-c/Analysis.h", "include/llvm-c/Analysis.h",
"include/llvm-c/Initialization.h", "include/llvm-c/Initialization.h",
], ],
copts = llvm_copts, copts = llvm_copts,
textual_hdrs = glob([ textual_hdrs = glob([
"include/llvm/Analysis/*.def", "include/llvm/Analysis/*.def",
]), ]),
▲ Show 20 Lines • Show All 3,392 Lines • Show Last 20 Lines