Turn on cold profile trimming by default for non-CS profile and use 10 as cold threshold which was well tuned number on our internal services.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
lgtm with a nit.
llvm/tools/llvm-profgen/ProfileGenerator.cpp | ||
---|---|---|
392–394 | If this functions takes ColdCntThreshold already, it'd be better to move the cold threshold setting out of it and pass in the final value. |
Comment Actions
As discussed offline, I will abandon this, user can specify the ProfileSummaryColdCount on their own side
If this functions takes ColdCntThreshold already, it'd be better to move the cold threshold setting out of it and pass in the final value.