This is an archive of the discontinued LLVM Phabricator instance.

[llvm-profgen] Turn on cold profile trimming by default for non-CS profile
AbandonedPublic

Authored by wlei on Dec 1 2021, 12:04 PM.

Details

Reviewers
hoy
wenlei
Summary

Turn on cold profile trimming by default for non-CS profile and use 10 as cold threshold which was well tuned number on our internal services.

Diff Detail

Event Timeline

wlei created this revision.Dec 1 2021, 12:04 PM
wlei requested review of this revision.Dec 1 2021, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2021, 12:04 PM
wlei edited the summary of this revision. (Show Details)Dec 1 2021, 12:10 PM
wlei added reviewers: hoy, wenlei.
hoy accepted this revision.Dec 2 2021, 3:05 PM

lgtm, thx.

This revision is now accepted and ready to land.Dec 2 2021, 3:05 PM
wlei retitled this revision from [llvm-profgen] Turn on cold profile trimming by default to [llvm-profgen] Turn on cold profile trimming by default for non-CS profile.Dec 6 2021, 9:26 AM
wlei edited the summary of this revision. (Show Details)
wenlei accepted this revision.Dec 8 2021, 12:06 PM

lgtm with a nit.

llvm/tools/llvm-profgen/ProfileGenerator.cpp
392–394

If this functions takes ColdCntThreshold already, it'd be better to move the cold threshold setting out of it and pass in the final value.

wlei abandoned this revision.Dec 8 2021, 12:23 PM

As discussed offline, I will abandon this, user can specify the ProfileSummaryColdCount on their own side