This is an archive of the discontinued LLVM Phabricator instance.

Unfortunately no. We didn't try to make a reproducer, we just have some CI compiling some internal test apps that's very strict about changes to the metrics it's tracking. Once we'd bisected the report to 5c77aa2b917c we found that the 'binary is different' flag was being set for some of the tests even though the commit said NFC

oops, thanks. LGTM.

No problem, thanks

Harbormaster completed remote builds in B136974: Diff 391092.Dec 1 2021, 1:08 PM

Closed by commit rG54e21df973e1: [unroll] Fix a functional change in an NFC patch (authored by dsanders). · Explain WhyDec 1 2021, 5:28 PM

This revision was automatically updated to reflect the committed changes.

dsanders added a commit: rG54e21df973e1: [unroll] Fix a functional change in an NFC patch.

Revision Contents

Path

Size

llvm/

lib/

Transforms/

Scalar/

LoopUnrollPass.cpp

2 lines

Diff 391173

llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp

	Show First 20 Lines • Show All 802 Lines • ▼ Show 20 Lines

	static Optional<unsigned> shouldFullUnroll(			static Optional<unsigned> shouldFullUnroll(
	Loop *L, const TargetTransformInfo &TTI, DominatorTree &DT,			Loop *L, const TargetTransformInfo &TTI, DominatorTree &DT,
	ScalarEvolution &SE, const SmallPtrSetImpl<const Value *> &EphValues,			ScalarEvolution &SE, const SmallPtrSetImpl<const Value *> &EphValues,
	const unsigned FullUnrollTripCount, const UnrollCostEstimator UCE,			const unsigned FullUnrollTripCount, const UnrollCostEstimator UCE,
	const TargetTransformInfo::UnrollingPreferences &UP) {			const TargetTransformInfo::UnrollingPreferences &UP) {
	assert(FullUnrollTripCount && "should be non-zero!");			assert(FullUnrollTripCount && "should be non-zero!");

	if (FullUnrollTripCount >= UP.FullUnrollMaxCount)			if (FullUnrollTripCount > UP.FullUnrollMaxCount)
	return None;			return None;

	// When computing the unrolled size, note that BEInsns are not replicated			// When computing the unrolled size, note that BEInsns are not replicated
	// like the rest of the loop body.			// like the rest of the loop body.
	if (UCE.getUnrolledLoopSize(UP) < UP.Threshold)			if (UCE.getUnrolledLoopSize(UP) < UP.Threshold)
	return FullUnrollTripCount;			return FullUnrollTripCount;

	// The loop isn't that small, but we still can fully unroll it if that			// The loop isn't that small, but we still can fully unroll it if that
	▲ Show 20 Lines • Show All 807 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[unroll] Fix a functional change in an NFC patchClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 391173

llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp

[unroll] Fix a functional change in an NFC patch
ClosedPublic