[lldb] Search PrivateFrameworks when using an internal SDK

[JDevlieghere]

Summary

Make sure to add the PrivateFrameworks directory to the frameworks path when using an internal SDK. This is necessary for the "on-device" test suite.

rdar://84519268

[aprantl]

lldb/packages/Python/lldbsuite/test/builders/darwin.py

86

Just curious: why not

args['FRAMEWORK_INCLUDES'] = '-F' + private_frameworks

?

[JDevlieghere]

lldb/packages/Python/lldbsuite/test/builders/darwin.py

86

Mostly for consistency with the rest of the file, but also personal preference. It's no coincidence that the rest of the file uses format too. I like f-strings even more, but they're Python 3.something only.

[kastiglione]

lldb/packages/Python/lldbsuite/test/builders/darwin.py

86

Maybe we can use format strings now? LLVM requires python >= 3.6, does that mean lldb does too? https://llvm.org/docs/GettingStarted.html#software

lldb/packages/Python/lldbsuite/test/builders/darwin.py

def getExtraMakeArgs(self):
         Helper function to return extra argumentsfor the make system. This
         method is meant to be overridden by platform specific builders.
         """
         args = dict()
 
         if configuration.dsymutil:
             args['DSYMUTIL'] = configuration.dsymutil
 
+        if 'internal' in configuration.apple_sdk:
+            sdk_root = lldbutil.get_xcode_sdk_root(configuration.apple_sdk)
+            if sdk_root:
+                private_frameworks = os.path.join(sdk_root, 'System',
+                                                  'Library',
+                                                  'PrivateFrameworks')
+                args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frameworks)
+
         operating_system, env = get_os_and_env()
         if operating_system and operating_system != "macosx":
             builder_dir = os.path.dirname(os.path.abspath(__file__))
             test_dir = os.path.dirname(builder_dir)
             if env == "simulator":
               entitlements_file = 'entitlements-simulator.plist'
             else:
               entitlements_file = 'entitlements.plist'