Page MenuHomePhabricator

[lldb] Search PrivateFrameworks when using an internal SDK
ClosedPublic

Authored by JDevlieghere on Nov 29 2021, 2:44 PM.

Details

Summary

Make sure to add the PrivateFrameworks directory to the frameworks path when using an internal SDK. This is necessary for the "on-device" test suite.

rdar://84519268

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Nov 29 2021, 2:44 PM
JDevlieghere created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2021, 2:44 PM
aprantl accepted this revision.Nov 30 2021, 10:48 AM
aprantl added inline comments.
lldb/packages/Python/lldbsuite/test/builders/darwin.py
86

Just curious: why not

args['FRAMEWORK_INCLUDES'] = '-F' + private_frameworks

?

This revision is now accepted and ready to land.Nov 30 2021, 10:48 AM
JDevlieghere marked an inline comment as done.Nov 30 2021, 11:19 AM
JDevlieghere added inline comments.Nov 30 2021, 11:25 AM
lldb/packages/Python/lldbsuite/test/builders/darwin.py
86

Mostly for consistency with the rest of the file, but also personal preference. It's no coincidence that the rest of the file uses format too. I like f-strings even more, but they're Python 3.something only.

kastiglione added inline comments.
lldb/packages/Python/lldbsuite/test/builders/darwin.py
86

Maybe we can use format strings now? LLVM requires python >= 3.6, does that mean lldb does too? https://llvm.org/docs/GettingStarted.html#software