This is an archive of the discontinued LLVM Phabricator instance.

Differential D114681

[AIX] Disable failing tests because of missing DWARF sections
ClosedPublic

Authored by Jake-Egan on Nov 28 2021, 5:54 PM.

Details

Reviewers
shchenz
dblaikie
Commits
rG143e42429480: [AIX] Disable failing tests because of missing DWARF sections
Summary

The following tests are failing due to missing DWARF sections: DwarfAccelNamesSection and DwarfAddrSection. This patch sets these tests as XFAIL until the sections can be implemented for AIX.

Diff Detail

Event Timeline

Jake-Egan requested review of this revision.Nov 28 2021, 5:54 PM
Jake-Egan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2021, 5:54 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Jake-Egan edited the summary of this revision. (Show Details)Nov 28 2021, 5:55 PM
Jake-Egan added a reviewer: shchenz.
Harbormaster completed remote builds in B136357: Diff 390231.Nov 28 2021, 6:34 PM
dblaikie added a subscriber: dblaikie.Nov 29 2021, 1:17 PM

Could you add a bit more detail about what DWARF sections are missing? Is this a missing feature for AIX DWARF that will be fixed in the future? (perhaps a FIXME/pointer to a bug/etc would be suitable as a comment, then)

Jake-Egan updated this revision to Diff 392401.Dec 7 2021, 7:53 AM

I updated the patch to add FIXME and added more detail to the description.

Jake-Egan edited the summary of this revision. (Show Details)Dec 7 2021, 7:54 AM
Harbormaster completed remote builds in B137910: Diff 392401.Dec 7 2021, 8:34 AM
dblaikie accepted this revision.Dec 7 2021, 10:23 AM

Sounds OK

This revision is now accepted and ready to land.Dec 7 2021, 10:23 AM
Closed by commit rG143e42429480: [AIX] Disable failing tests because of missing DWARF sections (authored by Jake-Egan). · Explain WhyDec 9 2021, 6:05 AM
This revision was automatically updated to reflect the committed changes.
Jake-Egan added a commit: rG143e42429480: [AIX] Disable failing tests because of missing DWARF sections.

Revision Contents

PathSize
llvm/
test/
DebugInfo/
Generic/
2 lines
2 lines

Diff 393133

llvm/test/DebugInfo/Generic/cross-cu-inlining.ll

; FIXME: Missing DwarfAccelNamesSection on AIX
; XFAIL: -aix
; RUN: %llc_dwarf -O0 -filetype=obj -dwarf-linkage-names=All < %s | llvm-dwarfdump -v -debug-info - | FileCheck -implicit-check-not=DW_TAG %s ; RUN: %llc_dwarf -O0 -filetype=obj -dwarf-linkage-names=All < %s | llvm-dwarfdump -v -debug-info - | FileCheck -implicit-check-not=DW_TAG %s
; RUN: %llc_dwarf -accel-tables=Apple -dwarf-linkage-names=All -O0 -filetype=obj < %s | llvm-dwarfdump -v - | FileCheck --check-prefix=CHECK-ACCEL --check-prefix=CHECK %s ; RUN: %llc_dwarf -accel-tables=Apple -dwarf-linkage-names=All -O0 -filetype=obj < %s | llvm-dwarfdump -v - | FileCheck --check-prefix=CHECK-ACCEL --check-prefix=CHECK %s
; Build from source: ; Build from source:
; $ clang++ a.cpp b.cpp -g -c -emit-llvm ; $ clang++ a.cpp b.cpp -g -c -emit-llvm
; $ llvm-link a.bc b.bc -o ab.bc ; $ llvm-link a.bc b.bc -o ab.bc
; $ opt -inline ab.bc -o ab-opt.bc ; $ opt -inline ab.bc -o ab-opt.bc
; $ cat a.cpp ; $ cat a.cpp
▲ Show 20 Lines • Show All 131 Lines • Show Last 20 Lines

llvm/test/DebugInfo/Generic/line-table-addrx.ll

; FIXME: Missing DwarfAddrSection on AIX
; XFAIL: -aix
; RUN: %llc_dwarf -filetype=obj %s -o - | llvm-dwarfdump -v -debug-info - | FileCheck %s ; RUN: %llc_dwarf -filetype=obj %s -o - | llvm-dwarfdump -v -debug-info - | FileCheck %s
;; In DWARF v5, emit DW_AT_addr_base as DW_AT_addr_base is used for DW_AT_low_pc. ;; In DWARF v5, emit DW_AT_addr_base as DW_AT_addr_base is used for DW_AT_low_pc.
; CHECK: DW_AT_low_pc [DW_FORM_addrx] ; CHECK: DW_AT_low_pc [DW_FORM_addrx]
; CHECK: DW_AT_addr_base ; CHECK: DW_AT_addr_base
define i64 @foo() !dbg !7 { define i64 @foo() !dbg !7 {
entry: entry:
Show All 13 Lines