This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Avoid overload resolution in path comparison operators
ClosedPublic

Authored by jloser on Nov 24 2021, 7:54 PM.

Details

Summary

Rework std::filesystem::path::operator== and friends to avoid overload
resolution and atomic constraint caching issues shown from
https://reviews.llvm.org/D113161.

Always call __compare(string_view) from the comparison operators which avoids
overload resolution.

Diff Detail

Event Timeline

jloser requested review of this revision.Nov 24 2021, 7:54 PM
jloser created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2021, 7:54 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Nov 25 2021, 8:34 AM
This revision is now accepted and ready to land.Nov 25 2021, 8:34 AM