This is an archive of the discontinued LLVM Phabricator instance.

Differential D114280

[InstSimplify] precommit tests for icmp of lshr/udiv fold (NFC)
ClosedPublic

Authored by erikdesjardins on Nov 19 2021, 1:20 PM.

Details

Reviewers
None
Commits
rGa68af62b422d: [InstSimplify] baseline tests for icmp of lshr/udiv fold (NFC)
Summary

Precommits tests for https://reviews.llvm.org/D114279

Diff Detail

Event Timeline

erikdesjardins requested review of this revision.Nov 19 2021, 1:20 PM
erikdesjardins created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2021, 1:21 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
erikdesjardins updated this revision to Diff 388613.Nov 19 2021, 1:22 PM

link orig diff

erikdesjardins added a child revision: D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.Nov 19 2021, 1:22 PM
erikdesjardins updated this revision to Diff 388614.Nov 19 2021, 1:24 PM
erikdesjardins edited the summary of this revision. (Show Details)

actually update description

Harbormaster completed remote builds in B135196: Diff 388614.Nov 19 2021, 2:41 PM
erikdesjardins updated this revision to Diff 389353.Nov 23 2021, 4:37 PM

improve test naming, add negative tests for a signed pred

Harbormaster completed remote builds in B135748: Diff 389353.Nov 23 2021, 5:58 PM
erikdesjardins mentioned this in D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.Nov 24 2021, 2:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 26 2021, 12:57 PM
Closed by commit rGa68af62b422d: [InstSimplify] baseline tests for icmp of lshr/udiv fold (NFC) (authored by erikdesjardins, committed by spatel). · Explain Why
This revision was automatically updated to reflect the committed changes.
spatel added a commit: rGa68af62b422d: [InstSimplify] baseline tests for icmp of lshr/udiv fold (NFC).

Revision Contents

PathSize
llvm/
test/
Transforms/
InstSimplify/
178 lines

Diff 388614

llvm/test/Transforms/InstSimplify/compare.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instsimplify -S | FileCheck %s ; RUN: opt < %s -instsimplify -S | FileCheck %s
target datalayout = "p:32:32-p1:64:64" target datalayout = "p:32:32-p1:64:64"
declare void @llvm.assume(i1)
define i1 @ptrtoint() { define i1 @ptrtoint() {
; CHECK-LABEL: @ptrtoint( ; CHECK-LABEL: @ptrtoint(
; CHECK-NEXT: ret i1 false ; CHECK-NEXT: ret i1 false
; ;
%a = alloca i8 %a = alloca i8
%tmp = ptrtoint i8* %a to i32 %tmp = ptrtoint i8* %a to i32
%r = icmp eq i32 %tmp, 0 %r = icmp eq i32 %tmp, 0
ret i1 %r ret i1 %r
▲ Show 20 Lines • Show All 558 Lines • ▼ Show 20 Lines
; CHECK-LABEL: @lshr7( ; CHECK-LABEL: @lshr7(
; CHECK-NEXT: ret i1 true ; CHECK-NEXT: ret i1 true
; ;
%A = lshr i32 %X, %Y %A = lshr i32 %X, %Y
%C = icmp uge i32 %X, %A %C = icmp uge i32 %X, %A
ret i1 %C ret i1 %C
} }
define i1 @lshr_nonzero1(i32 %x) {
; CHECK-LABEL: @lshr_nonzero1(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = lshr i32 [[X]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = lshr i32 %x, 1
%cmp = icmp eq i32 %lhs, %x
ret i1 %cmp
}
define i1 @lshr_nonzero2(i32 %x) {
; CHECK-LABEL: @lshr_nonzero2(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = lshr i32 [[X]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp uge i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = lshr i32 %x, 1
%cmp = icmp uge i32 %lhs, %x
ret i1 %cmp
}
define i1 @lshr_nonzero3(i32 %x) {
; CHECK-LABEL: @lshr_nonzero3(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = lshr i32 [[X]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = lshr i32 %x, 1
%cmp = icmp ne i32 %lhs, %x
ret i1 %cmp
}
define i1 @lshr_nonzero4(i32 %x) {
; CHECK-LABEL: @lshr_nonzero4(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = lshr i32 [[X]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = lshr i32 %x, 1
%cmp = icmp ult i32 %lhs, %x
ret i1 %cmp
}
; Negative test - unknown shift amount
define i1 @lshr_nonzero_neg1(i32 %x, i32 %c) {
; CHECK-LABEL: @lshr_nonzero_neg1(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = lshr i32 [[X]], [[C:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = lshr i32 %x, %c
%cmp = icmp ult i32 %lhs, %x
ret i1 %cmp
}
; Negative test - x may be zero
define i1 @lshr_nonzero_neg2(i32 %x, i32 %c) {
; CHECK-LABEL: @lshr_nonzero_neg2(
; CHECK-NEXT: [[LHS:%.*]] = lshr i32 [[X:%.*]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%lhs = lshr i32 %x, 1
%cmp = icmp ult i32 %lhs, %x
ret i1 %cmp
}
define i1 @ashr1(i32 %x) { define i1 @ashr1(i32 %x) {
; CHECK-LABEL: @ashr1( ; CHECK-LABEL: @ashr1(
; CHECK-NEXT: ret i1 false ; CHECK-NEXT: ret i1 false
; ;
%s = ashr i32 -1, %x %s = ashr i32 -1, %x
%c = icmp eq i32 %s, 0 %c = icmp eq i32 %s, 0
ret i1 %c ret i1 %c
} }
▲ Show 20 Lines • Show All 296 Lines • ▼ Show 20 Lines
; CHECK-LABEL: @udiv8( ; CHECK-LABEL: @udiv8(
; CHECK-NEXT: ret i1 true ; CHECK-NEXT: ret i1 true
; ;
%A = udiv i32 %X, %Y %A = udiv i32 %X, %Y
%C = icmp uge i32 %X, %A %C = icmp uge i32 %X, %A
ret i1 %C ret i1 %C
} }
define i1 @udiv_nonzero1(i32 %x) {
; CHECK-LABEL: @udiv_nonzero1(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = udiv i32 [[X]], 3
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = udiv i32 %x, 3
%cmp = icmp eq i32 %lhs, %x
ret i1 %cmp
}
define i1 @udiv_nonzero2(i32 %x) {
; CHECK-LABEL: @udiv_nonzero2(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = udiv i32 [[X]], 3
; CHECK-NEXT: [[CMP:%.*]] = icmp uge i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = udiv i32 %x, 3
%cmp = icmp uge i32 %lhs, %x
ret i1 %cmp
}
define i1 @udiv_nonzero3(i32 %x) {
; CHECK-LABEL: @udiv_nonzero3(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = udiv i32 [[X]], 3
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = udiv i32 %x, 3
%cmp = icmp ne i32 %lhs, %x
ret i1 %cmp
}
define i1 @udiv_nonzero4(i32 %x) {
; CHECK-LABEL: @udiv_nonzero4(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = udiv i32 [[X]], 3
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = udiv i32 %x, 3
%cmp = icmp ult i32 %lhs, %x
ret i1 %cmp
}
; Negative test - unknown divisor
define i1 @udiv_nonzero_neg1(i32 %x, i32 %c) {
; CHECK-LABEL: @udiv_nonzero_neg1(
; CHECK-NEXT: [[X_NE_0:%.*]] = icmp ne i32 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NE_0]])
; CHECK-NEXT: [[LHS:%.*]] = udiv i32 [[X]], [[C:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%x_ne_0 = icmp ne i32 %x, 0
call void @llvm.assume(i1 %x_ne_0)
%lhs = udiv i32 %x, %c
%cmp = icmp ult i32 %lhs, %x
ret i1 %cmp
}
; Negative test - x may be zero
define i1 @udiv_nonzero_neg2(i32 %x, i32 %c) {
; CHECK-LABEL: @udiv_nonzero_neg2(
; CHECK-NEXT: [[LHS:%.*]] = udiv i32 [[X:%.*]], 3
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[LHS]], [[X]]
; CHECK-NEXT: ret i1 [[CMP]]
;
%lhs = udiv i32 %x, 3
%cmp = icmp ult i32 %lhs, %x
ret i1 %cmp
}
; Square of a non-zero number is non-zero if there is no overflow. ; Square of a non-zero number is non-zero if there is no overflow.
define i1 @mul1(i32 %X) { define i1 @mul1(i32 %X) {
; CHECK-LABEL: @mul1( ; CHECK-LABEL: @mul1(
; CHECK-NEXT: ret i1 false ; CHECK-NEXT: ret i1 false
; ;
%Y = or i32 %X, 1 %Y = or i32 %X, 1
%M = mul nuw i32 %Y, %Y %M = mul nuw i32 %Y, %Y
%C = icmp eq i32 %M, 0 %C = icmp eq i32 %M, 0
▲ Show 20 Lines • Show All 1,611 Lines • Show Last 20 Lines