This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Fix incorrect comment about the purpose of LLVM_DEFAULT_TARGET_TRIPLE
ClosedPublic

Authored by ldionne on Nov 16 2021, 8:46 AM.

Details

Summary

5beec6fb04e7 added LLVM_DEFAULT_TARGET_TRIPLE to the runtimes build with
a comment, however I believe that comment had been copied from the LLVM
build tree. In the context of the runtimes, LLVM_DEFAULT_TARGET_TRIPLE
is used to set what targets we are building for, not the target for which
we "generate code".

Diff Detail

Event Timeline

ldionne created this revision.Nov 16 2021, 8:46 AM
ldionne requested review of this revision.Nov 16 2021, 8:46 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 16 2021, 8:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
phosek accepted this revision.Nov 16 2021, 12:34 PM

LGTM

ldionne accepted this revision.Nov 16 2021, 1:01 PM
This revision is now accepted and ready to land.Nov 16 2021, 1:01 PM

I believe that comment had been copied from the LLVM build tree

Correct, thanks for updating it.