This is an archive of the discontinued LLVM Phabricator instance.

Differential D114000

[libc++][nfc] Improve standard conformance.
ClosedPublic

Authored by Mordante on Nov 16 2021, 7:05 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGbfc253c00068: [libc++][nfc] Improve standard conformance.
Summary

The return type of the deleted functions doesn't match the synopsis in
the standard.

Diff Detail

Event Timeline

Mordante requested review of this revision.Nov 16 2021, 7:05 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 7:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne accepted this revision.Nov 16 2021, 7:21 AM
This revision is now accepted and ready to land.Nov 16 2021, 7:21 AM
Harbormaster completed remote builds in B134519: Diff 387628.Nov 16 2021, 8:27 AM
Closed by commit rGbfc253c00068: [libc++][nfc] Improve standard conformance. (authored by Mordante). · Explain WhyNov 16 2021, 8:30 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGbfc253c00068: [libc++][nfc] Improve standard conformance..
• Quuxplusone added a subscriber: • Quuxplusone.Nov 16 2021, 9:06 AM

@Mordante: Seems harmless enough (ship it!) but for my information, do you know of any way for the user to detect this change? My impression is that the return type of a deleted function is completely unobservable.

Mordante added a comment.Nov 16 2021, 10:27 AM
In D114000#3135172, @Quuxplusone wrote:

@Mordante: Seems harmless enough (ship it!) but for my information, do you know of any way for the user to detect this change? My impression is that the return type of a deleted function is completely unobservable.

I don't know it's indeed undetectable by the user.
I just noticed the odd return type while looking at compiler errors while working on the float formatter. (Caused by me using the wrong lit version.)

Revision Contents

PathSize
libcxx/
include/
4 lines

Diff 387660

libcxx/include/charconv

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Lines
namespace __itoa { namespace __itoa {
_LIBCPP_AVAILABILITY_TO_CHARS _LIBCPP_FUNC_VIS char* __u64toa(uint64_t __value, char* __buffer) _NOEXCEPT; _LIBCPP_AVAILABILITY_TO_CHARS _LIBCPP_FUNC_VIS char* __u64toa(uint64_t __value, char* __buffer) _NOEXCEPT;
_LIBCPP_AVAILABILITY_TO_CHARS _LIBCPP_FUNC_VIS char* __u32toa(uint32_t __value, char* __buffer) _NOEXCEPT; _LIBCPP_AVAILABILITY_TO_CHARS _LIBCPP_FUNC_VIS char* __u32toa(uint32_t __value, char* __buffer) _NOEXCEPT;
} }
#ifndef _LIBCPP_CXX03_LANG #ifndef _LIBCPP_CXX03_LANG
void to_chars(char*, char*, bool, int = 10) = delete; to_chars_result to_chars(char*, char*, bool, int = 10) = delete;
void from_chars(const char*, const char*, bool, int = 10) = delete; from_chars_result from_chars(const char*, const char*, bool, int = 10) = delete;
namespace __itoa namespace __itoa
{ {
static _LIBCPP_CONSTEXPR uint64_t __pow10_64[] = { static _LIBCPP_CONSTEXPR uint64_t __pow10_64[] = {
UINT64_C(0), UINT64_C(0),
UINT64_C(10), UINT64_C(10),
UINT64_C(100), UINT64_C(100),
▲ Show 20 Lines • Show All 486 Lines • Show Last 20 Lines